From: Lidong Yan <yldhome2d2@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jeff King <peff@peff•net>,
Lidong Yan via GitGitGadget <gitgitgadget@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH] diff: stop output garbled message in dry run mode
Date: Sun, 19 Oct 2025 22:31:27 +0800 [thread overview]
Message-ID: <DEF57576-E0E5-4F09-B7E7-CE1B8753F088@gmail.com> (raw)
In-Reply-To: <xmqqa51ow6xu.fsf@gitster.g>
Junio C Hamano <gitster@pobox•com> writes:
>
> Yup, that matches my expectation more closely, which is
>
> * We'll do the "send to /dev/null as we used to do before the
> dry-run thing" on the 'maint' front, which will be merged up to
> 'master' and above.
>
> * We'll queue "here are fixes to the recently introduced dry-run
> code" (without the /dev/null thing mixed in), and cook that in
> the usual 'seen' down to 'next' down to 'master' route.
>
> In a distant future, we may consider removing the /dev/null thing
> once the dry-run code path proves to be stable and robust.
>
> Thanks.
I am not sure what should I do. Should I make a new patch which
only contains “fixes to the recently introduced dry-run code” without
Peff’s code in it? Or Junio would do that for me?
Thanks,
Lidong
next prev parent reply other threads:[~2025-10-19 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 3:17 [PATCH] diff: stop output garbled message in dry run mode Lidong Yan via GitGitGadget
2025-10-17 12:07 ` Johannes Schindelin
2025-10-17 19:15 ` Junio C Hamano
2025-10-17 20:19 ` Junio C Hamano
2025-10-17 20:17 ` Junio C Hamano
2025-10-17 16:17 ` Junio C Hamano
2025-10-18 1:11 ` Lidong Yan
2025-10-18 5:02 ` Junio C Hamano
2025-10-18 9:47 ` Jeff King
2025-10-18 9:50 ` Lidong Yan
2025-10-18 9:56 ` Jeff King
2025-10-18 15:44 ` Junio C Hamano
2025-10-19 14:31 ` Lidong Yan [this message]
2025-10-19 15:33 ` Junio C Hamano
2025-10-18 9:48 ` [PATCH v2] " Lidong Yan
2025-10-19 16:20 ` [PATCH v3] " Lidong Yan
2025-10-19 16:30 ` [PATCH v4] " Lidong Yan
2025-10-22 19:53 ` Junio C Hamano
2025-10-22 21:33 ` Junio C Hamano
2025-10-23 0:27 ` Lidong Yan
2025-10-23 12:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEF57576-E0E5-4F09-B7E7-CE1B8753F088@gmail.com \
--to=yldhome2d2@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox