From: Lucas Seiki Oshiro <lucasseikioshiro@gmail•com>
To: SoutrikDas <valusoutrik@gmail•com>
Cc: jayatheerthkulkarni2005@gmail•com, ayu.chandekar@gmail•com,
git@vger•kernel.org, gitster@pobox•com, jltobler@gmail•com,
karthik.188@gmail•com, siddharthasthana31@gmail•com
Subject: Re: [RFC RFC PATCH] builtin/repo.c: change info default behavior to show all fields
Date: Wed, 25 Feb 2026 13:08:50 -0300 [thread overview]
Message-ID: <E0F6937A-7B0D-4162-9752-4AF5C6A88531@gmail.com> (raw)
In-Reply-To: <20260225153132.7387-1-valusoutrik@gmail.com>
Hi!
> Yup, after reading it I did realise how pointless my suggestion was.
I wouldn't say it was pointless, since you identified something that
you thought that could be improved, found the code to be changed and
sent a patch proposing your change.
The default behaviour of git-repo-info with no arguments was not a
complete consensus at the first place, some people thought it needed
to return all the values, and some thought that no value should be
returned.
Although in this case I was on the "winner" side (I'm using quotes
because I don't think this is a competition), many changes that I
did were rejected at first place, and I couldn't see at first what
were the problems with them, which I couldn't see only after the
reviewing process. The reviewing process is very strict, and it
couldn't be different, since Git is used by more than 90% of the
developers [2].
Finally, I must say that most things that I think that should do
falls under three situations:
1. Git already does that, and I didn't know
2. It was already discussed, and people agreed that Git shouldn't
do it
3. It's not possible to do that
In your case, it falls in the situation 2 and the discussion, being
already discussed [3]. But I understand that it can be frustrating
sometimes, and hope you don't feel discouraged in contributing to
Git.
[1] 20250610152117.14826-1-lucasseikioshiro@gmail•com
[2] https://survey.stackoverflow.co/2022/#version-control-version-control-system-prof
[3] 20250915223618.13093-1-lucasseikioshiro@gmail•com
prev parent reply other threads:[~2026-02-25 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 20:40 [RFC RFC PATCH] builtin/repo.c: change info default behavior to show all fields SoutrikDas
2026-02-24 21:03 ` [PATCH v2] " SoutrikDas
2026-02-24 21:23 ` [RFC RFC PATCH] " Junio C Hamano
2026-02-24 22:08 ` SoutrikDas
2026-02-25 0:14 ` K Jayatheerth
2026-02-25 2:44 ` Junio C Hamano
2026-02-25 15:34 ` SoutrikDas
2026-02-25 15:46 ` Junio C Hamano
2026-02-25 15:48 ` Kristoffer Haugsbakk
2026-02-25 17:02 ` JAYATHEERTH K
2026-02-25 15:11 ` Lucas Seiki Oshiro
2026-02-25 15:38 ` SoutrikDas
2026-02-25 15:31 ` SoutrikDas
2026-02-25 16:08 ` Lucas Seiki Oshiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0F6937A-7B0D-4162-9752-4AF5C6A88531@gmail.com \
--to=lucasseikioshiro@gmail$(echo .)com \
--cc=ayu.chandekar@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jayatheerthkulkarni2005@gmail$(echo .)com \
--cc=jltobler@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
--cc=siddharthasthana31@gmail$(echo .)com \
--cc=valusoutrik@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox