From: Hamza Mahfooz <someguy@effective-light•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH v12 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data
Date: Tue, 12 Oct 2021 19:01:28 -0400 [thread overview]
Message-ID: <GYZV0R.L35VU8UQBN4L2@effective-light.com> (raw)
In-Reply-To: <87a6jjlzz1.fsf@evledraar.gmail.com>
On Sat, Oct 9 2021 at 03:37:58 AM +0200, Ævar Arnfjörð Bjarmason
<avarab@gmail•com> wrote:
> Are there cases where my "utf8_all_the_things" POC patch would have
> turned on PCRE2_UTF, but yours doesn't? IOW is there a 1=1 mapping
> still
> between the encoding mode log/revision.c thinks it's in & PCRE2_UTF?
As far as I can tell, the only place where ignore_locale is mutated is
in
setup_revisions(), so there should be a 1=1 mapping.
prev parent reply other threads:[~2021-10-12 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 22:49 [PATCH v12 1/3] grep: refactor next_match() and match_one_pattern() for external use Hamza Mahfooz
2021-10-08 22:49 ` [PATCH v12 2/3] pretty: colorize pattern matches in commit messages Hamza Mahfooz
2021-10-08 22:49 ` [PATCH v12 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data Hamza Mahfooz
2021-10-09 1:37 ` Ævar Arnfjörð Bjarmason
2021-10-12 23:01 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GYZV0R.L35VU8UQBN4L2@effective-light.com \
--to=someguy@effective-light$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox