public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Jérémie Detrey" <Jeremie.Detrey@altu•fr>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Shulhan <m.shulhan@gmail•com>,
	Brandon Williams <bwilliams.eng@gmail•com>,
	Johannes Schindelin <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH] git-remote: load config whenever create_symref() might be called
Date: Sat, 26 Dec 2020 23:28:01 +0100	[thread overview]
Message-ID: <X+e48UEE4wf3fMNI@pica> (raw)
In-Reply-To: <xmqqeejcqlpq.fsf@gitster.c.googlers.com>

Hi,

Thanks for the feedback!

Junio C Hamano:
> My gut feeling says that the best place to call git_config() on
> git_default_config would actually be in cmd_remote(), immediately
> before we call parse_options() to parse the main options shared by
> all subcommands of "git remote".  Is there a reason why codepaths
> other than the three you singled out should *not* be affected by the
> basic set of configuration variables?

No, none that I can think of. I'll leave more knowledgeable people
than me confirm this, but if that's the way to go, I'll be happy to
submit a revised patch following your suggestion :)

Cheers,
Jérémie.

next prev parent reply	other threads:[~2020-12-26 22:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26 13:44 [PATCH] git-remote: load config whenever create_symref() might be called Jérémie Detrey
2020-12-26 21:52 ` Junio C Hamano
2020-12-26 22:28   ` Jérémie Detrey [this message]
2020-12-27  0:34     ` Eric Sunshine
2020-12-27  6:22       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+e48UEE4wf3fMNI@pica \
    --to=jeremie.detrey@altu$(echo .)fr \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=bwilliams.eng@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=m.shulhan@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox