Subject: Re: [PATCH v10 2/3] interpret-trailers: add own-identity option

From: Đoàn Trần Công Danh <[email-masked]>
Date: Thu, 18 Mar 2021 23:45:18 +0700

On 2021-03-18 11:15:55+0000, ZheNing Hu via GitGitGadget <[email-masked]> wrote:
> From: ZheNing Hu <[email-masked]>
> 
> Beacuse `git commit --trailer="Signed-off-by: \

s/Beacuse/Because/

And I think, it's easier to read if we write the command in its own
(indented) line.

> $(git config user.name) <$(git config user.email)>"`
> is difficult for users to add their own identities,
> so teach interpret-trailers a new option `--own-identity`
> which allow those trailers with no value add the user’s own
> identity. This will help the use of `commit --trailer` as
> easy as `--signoff`.

Perhap, saying that we're optionalise <value> in --trailer, by
substitute user's identity if missing instead?

> @@ -131,6 +144,7 @@ OPTIONS
>  	when you know your input contains just the commit message itself
>  	(and not an email or the output of `git format-patch`).
>  
> +

I think it's better to not add this line change

>  CONFIGURATION VARIABLES
>  -----------------------
>  
> diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c
> index 84748eafc01b..be7f502a58d7 100644
> --- a/builtin/interpret-trailers.c
> +++ b/builtin/interpret-trailers.c

-- 
Danh