Subject: Re: [PATCH] git-p4: fix failed submit by skip non-text data files

From: Simon Hausmann <[email-masked]>
Date: Fri, 18 Jun 2021 16:54:11 +0200

On Fri, Mar 12, 2021 at 07:47:49AM +0000, dorgon chang via GitGitGadget wrote:
> From: "dorgon.chang" <[email-masked]>
> 
> If the submit contain binary files, it will throw exception and stop submit when try to append diff line description.
> 
> This commit will skip non-text data files when exception UnicodeDecodeError thrown.
> 
> Signed-off-by: dorgon.chang <[email-masked]>
> ---
>     git-p4: fix failed submit by skip non-text data files
>     
>     git-p4: fix failed submit by skip non-text data files
>     
>     If the submit contain binary files, it will throw exception and stop
>     submit when try to append diff line description.
>     
>     This commit will skip non-text data files when exception
>     UnicodeDecodeError thrown.
>     
>     I am using git-p4 with UnrealEngine game projects and this fix works for
>     me.
>     
>     Signed-off-by: dorgon.chang [email-masked]

As suggested on
https://github.com/git/git/pull/977#issuecomment-862197824, I'm happy to
state that the patch looks good to me. IIRC the diff there is solely for
the submit template, so it should only include text. That your patch
ensures in what seems an idiomatic way.

Reviewed-by: Simon Hausmann <[email-masked]>

Simon