Subject: Re: [PATCH v8 00/17] fsck: lib-ify object-file.c & better fsck "invalid object" error reporting

From: Taylor Blau <[email-masked]>
Date: Wed, 29 Sep 2021 15:50:24 -0400

On Tue, Sep 28, 2021 at 04:18:41AM +0200, Ævar Arnfjörð Bjarmason wrote:
> This improves fsck error reporting, see the examples in the commit
> messages of 16/17 and 17/17. To get there I've lib-ified more things
> in object-file.c and the general object APIs, i.e. now we'll return
> error codes instead of calling die() in these cases.
>
> v6 of this got a very detailed review from Taylor Blau (thanks a
> lot!), for the v6 see:
> https://lore.kernel.org/git/[email-masked]/
>
> The v7 had a couple of trivial shellscripting issues, a typo'd
> test_oid variable, and a warning on a "test" comparison. For v7 see
> https://lore.kernel.org/git/[email-masked]/

Thanks; I looked at the range-diff and it addresses both of my comments.

This series looks good to me.

Thanks,
Taylor