From: Josh Steadmon <steadmon@google•com>
To: Frantisek Hrbata <frantisek@hrbata•com>
Cc: git@vger•kernel.org, "Jonathan Tan" <jonathantanmy@google•com>,
"Junio C Hamano" <gitster@pobox•com>,
"Brandon Williams" <bwilliams.eng@gmail•com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: [PATCH v3 0/3] fix memory leaks in transport_push()
Date: Fri, 27 May 2022 13:22:53 -0700 [thread overview]
Message-ID: <YpEzHfrD4e0S2Sjq@google.com> (raw)
In-Reply-To: <20220520124952.2393299-1-frantisek@hrbata.com>
On 2022.05.20 14:49, Frantisek Hrbata wrote:
> Fix memory leaks in transport_push(), where remote_refs and local_refs
> are never freed. While at it, remove the unnecessary indenting and make
> the code hopefully more readable.
>
> Changes since v2:
>
> * "transport: remove unnecessary indenting in transport_push()"
> s/push_refs/transport_push/ in commit message as noticed
> by Ævar Arnfjörð Bjarmason
>
> * "transport: unify return values and exit point from transport_push()"
> Added as suggested by Ævar Arnfjörð Bjarmason. It allows the following
> memory leak fix to be a very simple patch.
>
> * "transport: free local and remote refs in transport_push()"
> Just free remote_refs and local_refs. The other changes were
> included in the previous patch.
>
> Changes since v1:
>
> * Slit into series of two patches. The first one just changes
> indenting in transport_push(). Second one adds the fix for
> the local_refs and remote_refs memory leaks.
>
> * The resulting trees are the same, there is no code change.
>
> Frantisek Hrbata (3):
> transport: remove unnecessary indenting in transport_push()
> transport: unify return values and exit point from transport_push()
> transport: free local and remote refs in transport_push()
>
> transport.c | 260 +++++++++++++++++++++++++++-------------------------
> 1 file changed, 133 insertions(+), 127 deletions(-)
Sorry for the late review. This all looks good to me, thanks for the
fix!
Reviewed-by: Josh Steadmon <steadmon@google•com>
prev parent reply other threads:[~2022-05-27 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:17 [PATCH] transport: free local and remote refs in transport_push() Frantisek Hrbata
2022-05-20 8:40 ` Ævar Arnfjörð Bjarmason
2022-05-20 8:56 ` Frantisek Hrbata
2022-05-20 10:35 ` [PATCH v2 0/2] fix memory leaks " Frantisek Hrbata
2022-05-20 10:35 ` [PATCH v2 1/2] transport: remove unnecessary indenting " Frantisek Hrbata
2022-05-20 11:24 ` Ævar Arnfjörð Bjarmason
2022-05-20 11:53 ` Frantisek Hrbata
2022-05-20 10:35 ` [PATCH v2 2/2] transport: free local and remote refs " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 0/3] fix memory leaks " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 1/3] transport: remove unnecessary indenting " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 2/3] transport: unify return values and exit point from transport_push() Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 3/3] transport: free local and remote refs in transport_push() Frantisek Hrbata
2022-05-27 20:22 ` Josh Steadmon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpEzHfrD4e0S2Sjq@google.com \
--to=steadmon@google$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=bwilliams.eng@gmail$(echo .)com \
--cc=frantisek@hrbata$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jonathantanmy@google$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox