From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Jason Yundt <jason@jasonyundt•email>
Cc: git@vger•kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: [PATCH] gitweb: switch to a modern DOCTYPE
Date: Thu, 2 Jun 2022 00:41:54 +0000 [thread overview]
Message-ID: <YpgHUm93840oBtib@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20220601012647.1439480-1-jason@jasonyundt.email>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
On 2022-06-01 at 01:26:47, Jason Yundt wrote:
> According to the HTML Standard FAQ:
>
> “What is the DOCTYPE for modern HTML documents?
>
> In text/html documents:
>
> <!DOCTYPE html>
>
> In documents delivered with an XML media type: no DOCTYPE is required
> and its use is generally unnecessary. However, you may use one if you
> want (see the following question). Note that the above is well-formed
> XML.”
>
> Source: [1]
>
> Gitweb uses an XHTML 1.0 DOCTYPE:
>
> <!DOCTYPE html PUBLIC
> "-//W3C//DTD XHTML 1.0 Strict//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
>
> While that DOCTYPE is still valid [2], it has several disadvantages:
>
> 1. It’s misleading. The DTD that browsers are supposed to use with that
> DOCTYPE has nothing to do with XHTML 1.0 and isn’t available at the URL
> that is given [2].
While the WHATWG may claim that, an XML parser is absolutely within its
rights to refer to and use that DTD, and in fact should do so unless its
catalog directs it elsewhere. It may be that some browsers use an
internal catalog that refers to a different DTD, however.
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 606b50104c..1835487ab2 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4219,7 +4219,10 @@ sub git_header_html {
> my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : '';
> print <<EOF;
> <?xml version="1.0" encoding="utf-8"?>
> -<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> +<!DOCTYPE html [
> + <!ENTITY nbsp " ">
> + <!ENTITY sdot "⋅">
> +]>
I think this should be fine. It defines the entities we need and
appears to be valid XML. I don't think there should be any problem
upgrading to XHTML 5 here.
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2022-06-02 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 1:26 [PATCH] gitweb: switch to a modern DOCTYPE Jason Yundt
2022-06-02 0:41 ` brian m. carlson [this message]
2022-06-02 6:10 ` Junio C Hamano
2022-06-02 7:26 ` Bagas Sanjaya
2022-06-02 11:43 ` [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE Jason Yundt
2022-06-02 18:50 ` Junio C Hamano
2022-06-02 19:51 ` Jason Yundt
2022-06-02 21:47 ` brian m. carlson
2022-06-02 22:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpgHUm93840oBtib@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste$(echo .)net \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jason@jasonyundt$(echo .)email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox