From: Patrick Steinhardt <ps@pks•im>
To: Junio C Hamano <gitster@pobox•com>
Cc: Christian Couder <christian.couder@gmail•com>,
git@vger•kernel.org, "D. Ben Knoble" <ben.knoble@gmail•com>
Subject: Re: [PATCH v2 5/5] remote: announce removal of "branches/" and "remotes/"
Date: Thu, 9 Jan 2025 11:20:29 +0100 [thread overview]
Message-ID: <Z3-i5mB4JVeONy4O@pks.im> (raw)
In-Reply-To: <xmqq4j2avaam.fsf@gitster.g>
On Tue, Jan 07, 2025 at 08:49:37AM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox•com> writes:
>
> > Patrick Steinhardt <ps@pks•im> writes:
> >
> >> Makes sense indeed. We can easily add for something like below diff.
> >> I'll roll that into the next version, thanks!
> >
> > It is a good start, but is probably a bit too noisy. Can we make
> > them appear ONLY when the definitions read from these older sources
> > are actually USED?
> >
> > Thanks.
>
> Something along this line is what I had in mind. Not even compile
> tested, and I am not claiming that all the uses of remote will go
> thourgh the code paths to use it with a transport, but you hopefully
> got the idea.
I had a look at your idea now, but I'm not convinced that it would be a
significantly improvement over my version. In almost all cases where we
execute `remote_get()` we'd also end up using the remote itself. So we'd
either have to add the explicit warning to all such locations, or we
risk not warning in cases where we really should.
The result of `remote_get()` (and `remotes_remote_get()`) is also being
cached, so if we retrieve the same remote multiple times from the same
remote state we'd only see the warning once.
So I'm inclined to leave this as-is, maybe adding an escape hatch to
silence the warnings via an environment variable to give users a bit of
time to migrate.
Patrick
next prev parent reply other threads:[~2025-01-09 10:20 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 10:56 [PATCH 0/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2024-12-11 13:06 ` Kristoffer Haugsbakk
2024-12-13 5:26 ` Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 0/5] " Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-06 13:20 ` Christian Couder
2025-01-06 13:20 ` Christian Couder
2025-01-06 7:51 ` [PATCH v2 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-06 13:25 ` Christian Couder
2025-01-06 15:51 ` Junio C Hamano
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 13:54 ` Christian Couder
2025-01-06 7:51 ` [PATCH v2 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-06 13:24 ` Christian Couder
2025-01-06 15:53 ` Junio C Hamano
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 16:40 ` Junio C Hamano
2025-01-07 16:49 ` Junio C Hamano
2025-01-07 16:55 ` rsbecker
2025-01-08 6:36 ` Patrick Steinhardt
2025-01-08 17:09 ` Junio C Hamano
2025-01-09 10:06 ` Patrick Steinhardt
2025-01-09 12:08 ` Robert Coup
2025-01-09 10:20 ` Patrick Steinhardt [this message]
2025-01-09 15:54 ` Junio C Hamano
2025-01-06 15:42 ` [PATCH v2 0/5] " Junio C Hamano
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 16:36 ` Junio C Hamano
2025-01-20 7:42 ` [PATCH v3 " Patrick Steinhardt
2025-01-20 7:42 ` [PATCH v3 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-20 7:42 ` [PATCH v3 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-20 7:43 ` [PATCH v3 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-20 7:43 ` [PATCH v3 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-21 21:09 ` Junio C Hamano
2025-01-20 7:43 ` [PATCH v3 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-21 21:25 ` Junio C Hamano
2025-01-22 11:05 ` Patrick Steinhardt
2025-01-22 17:58 ` Junio C Hamano
2025-01-22 11:31 ` [PATCH v4 0/5] " Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-22 20:32 ` Junio C Hamano
2025-02-21 15:26 ` Jakub Wilk
2025-02-21 18:30 ` Junio C Hamano
2025-02-25 7:58 ` Patrick Steinhardt
2025-02-25 23:45 ` Junio C Hamano
2025-02-26 9:21 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3-i5mB4JVeONy4O@pks.im \
--to=ps@pks$(echo .)im \
--cc=ben.knoble@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox