From: Patrick Steinhardt <ps@pks•im>
To: "D. Ben Knoble" <ben.knoble@gmail•com>
Cc: Git <git@vger•kernel.org>
Subject: Re: [PATCH 5/5] remote: announce removal of "branches/" and "remotes/"
Date: Mon, 6 Jan 2025 08:51:10 +0100 [thread overview]
Message-ID: <Z3uLLv8DjEicYnNF@pks.im> (raw)
In-Reply-To: <0F4D68EB-27F9-4638-98CD-02515969D677@gmail.com>
On Sat, Jan 04, 2025 at 10:36:10AM -0500, D. Ben Knoble wrote:
> > +As our documentation mentions, these directories are not to be found in modern
> > +repositories at all and most users aren't even aware of these mechanisms. They
> > +have been deprecated for almost 20 years and 14 years respectively, and I am
> > +not aware of any reason why anybody would want to use these mechanisms.
> > +Furthermore, the ".git/branches/" directory is noadays misleadingly named and
> > +may cause confusion as "branches" are almost exclusively used in the context of
> > +references.
>
> s/noadays/nowadays
Thanks, will fix.
> Is the first-person intended? "I am not aware" reads like editorial that doesn't
> match with the rest of the document (either "we" or technical-passive voice).
Hm. Yes, it was intended initially, mostly because I wanted to stress
that this is *my* finding and may not reflect the whole project's
stance. But while that would've been fine in a commit message, I think
you're right and it's less sensible in a committed document. After all,
the review process should ensure that the project also agrees with my
finding, and at that point it does make sense to say "we".
> (PS hopefully my mail client will get this to the right place)
Seems like it did make it to the right place. There is one weirdness
though: your mail client sets the "Reply-To" header to the message ID of
the cover letter somehow, so when replying I don't send it to you but I
instead send it to [1].
[1]: 20241211-pks-remote-branches-deprecation-v1-5-1431e2369135@pks•im
Patrick
next prev parent reply other threads:[~2025-01-06 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 15:36 [PATCH 5/5] remote: announce removal of "branches/" and "remotes/" D. Ben Knoble
2025-01-06 7:51 ` Patrick Steinhardt [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-11 10:56 [PATCH 0/5] " Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 5/5] " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3uLLv8DjEicYnNF@pks.im \
--to=ps@pks$(echo .)im \
--cc=ben.knoble@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox