From: Patrick Steinhardt <ps@pks•im>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, Phillip Wood <phillip.wood@dunelm•org.uk>
Subject: Re: [PATCH 02/10] t7422: fix flaky test caused by buffered stdout
Date: Tue, 7 Jan 2025 09:50:06 +0100 [thread overview]
Message-ID: <Z3zqvn82UJIxA9yW@pks.im> (raw)
In-Reply-To: <Z3zqKSx8NVK-QQNL@pks.im>
On Tue, Jan 07, 2025 at 09:47:44AM +0100, Patrick Steinhardt wrote:
> On Mon, Jan 06, 2025 at 09:39:04PM -0500, Jeff King wrote:
> > So I don't really see a way to do this robustly.
>
> I think I found a way, which goes back to the inital idea of just
> generating heaps of submodules. My current version generates a submodule
> "A" with a couple of recursive submodules followed by 2.5k additional
> submodules, which overall generates ~150kB of data. This can be done
> somewhat efficiently via git-hash-object-object(1) and git-mktree(1),
> and things work with a sleep before and after the call to grep(1).
>
> I'm a bit torn though. The required setup is quite complex, and I wonder
> whether it is really worth it just to test this edge case. On the other
> hand it is there to cover a recent fix in 082caf527e (submodule status:
> propagate SIGPIPE, 2024-09-20), so losing the test coverage isn't all
> that great, either. And keeping the race is not an option to me, either.
>
> So I'm inclined to go with the below version. WDYT?
Gah, this of course needs to be adapted so that it is the submodule that
contains 2.5k recursive submodules. But the idea would still work.
Patrick
next prev parent reply other threads:[~2025-01-07 8:50 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 14:46 [PATCH 00/10] A couple of CI improvements Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 01/10] t0060: fix EBUSY in MinGW when setting up runtime prefix Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 02/10] t7422: fix flaky test caused by buffered stdout Patrick Steinhardt
2025-01-03 18:17 ` Jeff King
2025-01-06 11:12 ` Patrick Steinhardt
2025-01-07 2:39 ` Jeff King
2025-01-07 8:47 ` Patrick Steinhardt
2025-01-07 8:50 ` Patrick Steinhardt [this message]
2025-01-09 7:17 ` Jeff King
2025-01-09 16:16 ` Junio C Hamano
2025-01-07 2:48 ` Jeff King
2025-01-07 16:02 ` Junio C Hamano
2025-01-03 14:46 ` [PATCH 03/10] github: adapt containerized jobs to be rootless Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 04/10] github: convert all Linux jobs to be containerized Patrick Steinhardt
2025-01-03 18:56 ` Jeff King
2025-01-03 19:06 ` Jeff King
2025-01-06 11:12 ` Patrick Steinhardt
2025-01-03 19:16 ` Junio C Hamano
2025-01-03 14:46 ` [PATCH 05/10] github: simplify computation of the job's distro Patrick Steinhardt
2025-01-03 19:09 ` Junio C Hamano
2025-01-03 14:46 ` [PATCH 06/10] gitlab-ci: remove the "linux-old" job Patrick Steinhardt
2025-01-03 19:12 ` Junio C Hamano
2025-01-03 14:46 ` [PATCH 07/10] gitlab-ci: add linux32 job testing against i386 Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 08/10] ci: stop special-casing for Ubuntu 16.04 Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 09/10] ci: use latest Ubuntu release Patrick Steinhardt
2025-01-03 14:46 ` [PATCH 10/10] ci: remove stale code for Azure Pipelines Patrick Steinhardt
2025-01-03 18:57 ` [PATCH 00/10] A couple of CI improvements Jeff King
2025-01-06 11:16 ` [PATCH v2 " Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 01/10] t0060: fix EBUSY in MinGW when setting up runtime prefix Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 02/10] t7422: fix flaky test caused by buffered stdout Patrick Steinhardt
2025-01-07 2:49 ` Jeff King
2025-01-06 11:16 ` [PATCH v2 03/10] github: adapt containerized jobs to be rootless Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 04/10] github: convert all Linux jobs to be containerized Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 05/10] github: simplify computation of the job's distro Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 06/10] gitlab-ci: remove the "linux-old" job Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 07/10] gitlab-ci: add linux32 job testing against i386 Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 08/10] ci: stop special-casing for Ubuntu 16.04 Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 09/10] ci: use latest Ubuntu release Patrick Steinhardt
2025-01-06 11:16 ` [PATCH v2 10/10] ci: remove stale code for Azure Pipelines Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 00/10] A couple of CI improvements Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 01/10] t0060: fix EBUSY in MinGW when setting up runtime prefix Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 02/10] t7422: fix flaky test caused by buffered stdout Patrick Steinhardt
2025-01-09 7:33 ` Jeff King
2025-01-07 12:30 ` [PATCH v3 03/10] github: adapt containerized jobs to be rootless Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 04/10] github: convert all Linux jobs to be containerized Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 05/10] github: simplify computation of the job's distro Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 06/10] gitlab-ci: remove the "linux-old" job Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 07/10] gitlab-ci: add linux32 job testing against i386 Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 08/10] ci: stop special-casing for Ubuntu 16.04 Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 09/10] ci: use latest Ubuntu release Patrick Steinhardt
2025-01-07 12:30 ` [PATCH v3 10/10] ci: remove stale code for Azure Pipelines Patrick Steinhardt
2025-01-10 11:31 ` [PATCH v4 00/10] A couple of CI improvements Patrick Steinhardt
2025-01-10 11:31 ` [PATCH v4 01/10] t0060: fix EBUSY in MinGW when setting up runtime prefix Patrick Steinhardt
2025-01-10 11:31 ` [PATCH v4 02/10] t7422: fix flaky test caused by buffered stdout Patrick Steinhardt
2025-01-24 9:16 ` Christian Couder
2025-01-10 11:31 ` [PATCH v4 03/10] github: adapt containerized jobs to be rootless Patrick Steinhardt
2025-01-24 9:56 ` Christian Couder
2025-08-28 9:58 ` Johannes Schindelin
2025-11-17 17:30 ` Johannes Schindelin
2025-01-10 11:32 ` [PATCH v4 04/10] github: convert all Linux jobs to be containerized Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 05/10] github: simplify computation of the job's distro Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 06/10] gitlab-ci: remove the "linux-old" job Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 07/10] gitlab-ci: add linux32 job testing against i386 Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 08/10] ci: stop special-casing for Ubuntu 16.04 Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 09/10] ci: use latest Ubuntu release Patrick Steinhardt
2025-01-10 11:32 ` [PATCH v4 10/10] ci: remove stale code for Azure Pipelines Patrick Steinhardt
2025-01-10 12:03 ` [PATCH v4 00/10] A couple of CI improvements Jeff King
2025-01-24 9:59 ` Christian Couder
2025-01-27 7:00 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3zqvn82UJIxA9yW@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox