From: Patrick Steinhardt <ps@pks•im>
To: "brian m. carlson" <sandals@crustytoothpaste•net>, git@vger•kernel.org
Cc: Karthik Nayak <karthik.188@gmail•com>
Subject: Re: Bug in 2.48 with `git refs migrate`
Date: Mon, 13 Jan 2025 16:45:35 +0100 [thread overview]
Message-ID: <Z4U1H6pe0NL0cOBh@pks.im> (raw)
In-Reply-To: <Z4UbkcmJAU1MT-Rs@tapette.crustytoothpaste.net>
On Mon, Jan 13, 2025 at 01:56:33PM +0000, brian m. carlson wrote:
> If you remove the second block, it does not appear to reproduce. Some
> investigation led me to the conclusion that the difference is when
> max_update_index is not 1, the header has the value 1 for it but the
> trailer has the correct value, and so we flag the header and trailer as
> mismatching and therefore it gets marked as corrupt. I believe the
> reason things work when removing the second block is because that value
> remains 1, and so it works.
Hm. Makes me wonder whether this is caused by the newly added code to
also migrate reflog entries, as we'd play around with the update index
only when migrating those. Cc'ing Karthik so he can have a look.
> I haven't done anything else to investigate here, for which I apologize,
> but I just wanted to mention it while it was fresh on my mind.
>
> In case this is helpful, I did see this when attempting to migrate two
> work repositories with lots of reflogs and many refs (the smaller has
> 2983 and the larger, 44832). I obviously cannot send you these
> repositories or things in them, but I'm happy to test patches against
> them.
>
> Please let me know if I can provide more useful information.
Thanks for your report!
Patrick
next prev parent reply other threads:[~2025-01-13 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 13:56 Bug in 2.48 with `git refs migrate` brian m. carlson
2025-01-13 15:45 ` Patrick Steinhardt [this message]
2025-01-15 11:54 ` Karthik Nayak
2025-01-15 17:07 ` Junio C Hamano
2025-01-16 6:44 ` Karthik Nayak
2025-01-16 2:05 ` brian m. carlson
2025-01-16 7:29 ` Karthik Nayak
2025-01-16 23:21 ` brian m. carlson
2025-01-17 0:04 ` Junio C Hamano
2025-01-17 6:17 ` Karthik Nayak
2025-01-17 6:15 ` Karthik Nayak
2025-01-23 13:56 ` [PATCH v2] reftable: write correct max_update_index to header Karthik Nayak
2025-01-23 18:11 ` Junio C Hamano
2025-01-23 18:24 ` Junio C Hamano
2025-01-24 14:02 ` [PATCH v3] refs: fix uninitialized memory access of `max_index` Karthik Nayak
2025-01-24 14:46 ` Patrick Steinhardt
2025-01-24 15:48 ` Karthik Nayak
2025-01-27 10:20 ` Patrick Steinhardt
2025-01-27 16:24 ` Junio C Hamano
2025-01-24 4:06 ` [PATCH v2] reftable: write correct max_update_index to header Karthik Nayak
2025-01-24 15:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4U1H6pe0NL0cOBh@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox