Subject: Re: [PATCH 3/5] pack-write: pass hash_algo to `write_idx_file()`

From: Patrick Steinhardt <[email-masked]>
Date: Thu, 16 Jan 2025 14:24:28 +0100

On Thu, Jan 16, 2025 at 12:35:15PM +0100, Karthik Nayak via B4 Relay wrote:
> @@ -546,7 +547,8 @@ void rename_tmp_packfile_idx(struct strbuf *name_buffer,
>  	rename_tmp_packfile(name_buffer, *idx_tmp_name, "idx");
>  }
>  
> -void stage_tmp_packfiles(struct strbuf *name_buffer,
> +void stage_tmp_packfiles(const struct git_hash_algo *hash_algo,
> +			 struct strbuf *name_buffer,
>  			 const char *pack_tmp_name,
>  			 struct pack_idx_entry **written_list,
>  			 uint32_t nr_written,

This change was somewhat unexpected to me as it wasn't mentioned, so it
makes you wonder why it's different than `wried_idx_file()`.

Patrick