Subject: Re: [PATCH v3 4/8] pack-objects: add GIT_TEST_NAME_HASH_VERSION

From: Taylor Blau <[email-masked]>
Date: Wed, 22 Jan 2025 17:20:47 -0500

On Fri, Dec 20, 2024 at 05:19:50PM +0000, Derrick Stolee via GitGitGadget wrote:
> @@ -209,6 +209,10 @@ test_expect_success 'bitmapPseudoMerge.stableThreshold creates stable groups' '
>  '
>
>  test_expect_success 'out of order thresholds are rejected' '
> +	# Disable this option to avoid stderr message
> +	GIT_TEST_NAME_HASH_VERSION=1 &&
> +	export GIT_TEST_NAME_HASH_VERSION &&
> +
>  	test_must_fail git \
>  		-c bitmapPseudoMerge.test.pattern="refs/*" \
>  		-c bitmapPseudoMerge.test.threshold=1.month.ago \

This is the only one that sets GIT_TEST_NAME_HASH_VERSION via an export.
I suspect that this is to get around calling the shell function with a
single-shot environment variable. But I think our convention for this is

    test_must_fail env GIT_TEST_NAME_HASH_VERSION=1 git ...

Probably not a big deal, but I figured I'd mention it regardless in case
you happen to reroll.

Thanks,
Taylor