From: Taylor Blau <me@ttaylorr•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Derrick Stolee <stolee@gmail•com>, git@vger•kernel.org
Subject: Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)
Date: Thu, 23 Jan 2025 18:05:24 -0500 [thread overview]
Message-ID: <Z5LLNMKSa6Y2zvHK@nand.local> (raw)
In-Reply-To: <xmqqh65qv6oc.fsf@gitster.g>
On Wed, Jan 22, 2025 at 02:13:07PM -0800, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr•com> writes:
>
> > On Tue, Jan 21, 2025 at 12:30:08PM -0800, Junio C Hamano wrote:
> >> Derrick Stolee <stolee@gmail•com> writes:
> >>
> >> > On 1/17/25 7:42 PM, Junio C Hamano wrote:
> >> >
> >> >> * ds/name-hash-tweaks (2024-12-20) 8 commits
> >> ...
> >> I am happy with the updated function that gives us better of both
> >> worlds, without losing too much from the "renamed from other
> >> directory" while making sure we do not lose too many bits in deeper
> >> trees.
> >
> > I had a couple of thoughts that I meant to share before the holiday
> > break, and haven't quite had a chance to get to it now that I'm back at
> > my desk.
> >
> > Let me try and find some time to respond to the latest round of this
> > series, and apologies for holding it up in the meantime.
>
> The topic has been stalled for unusually long time, so it won't hurt
> too much for it to wait for a few more days, but it wouldn't be fair
> to stall a topic further with just a promise to "try and find time"
> forever. Let's say we'll go ahead by this weekend unless we hear
> otherwise?
I agree, and I apologize for the delay. I prioritized this yesterday and
left some review which I think you have seen since sending this email.
> I am not ultra-happy with the last step, as I personally do not see
> this different algorithm as "version" (in that people would always
> want to use version N+1 over version N when both are available) but
> as "variant" (in that there may be prefer to use variant N over
> variant N+1 depending on the circumstances), but that may be just
> the matter of terminology. What's important is to make sure we do
> not mix two algorhtims up while creating a packfile.
Yeah, I think "variant" is probably more accurate, but I don't mind the
naming. I think having a unique identifier is important, but I am not
convinced that we need to introduce v2 and v3 at the same time. I would
rather see us unify behind a single approach to present a
clearer/smaller set of options to users.
Thanks,
Taylor
next prev parent reply other threads:[~2025-01-23 23:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 0:42 What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-18 13:15 ` Jeff King
2025-01-18 17:17 ` Junio C Hamano
2025-01-19 12:51 ` Jeff King
2025-01-19 12:55 ` Jeff King
2025-01-21 19:17 ` Junio C Hamano
2025-01-20 6:53 ` David Aguilar
2025-01-20 7:54 ` [PATCH] help: make help.autocorrect = 1 the same as "prompt" David Aguilar
2025-01-21 19:23 ` What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-21 20:19 ` Derrick Stolee
2025-01-21 20:30 ` Junio C Hamano
2025-01-22 18:30 ` Taylor Blau
2025-01-22 22:13 ` Junio C Hamano
2025-01-23 23:05 ` Taylor Blau [this message]
2025-01-23 23:46 ` Junio C Hamano
2025-01-22 16:44 ` Karthik Nayak
2025-01-22 17:28 ` Karthik Nayak
2025-01-22 17:38 ` Junio C Hamano
2025-01-23 17:22 ` Junio C Hamano
2025-01-23 17:45 ` Patrick Steinhardt
2025-01-23 18:25 ` Junio C Hamano
2025-01-24 11:05 ` Karthik Nayak
2025-01-24 17:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5LLNMKSa6Y2zvHK@nand.local \
--to=me@ttaylorr$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox