From: Patrick Steinhardt <ps@pks•im>
To: Usman Akinyemi <usmanakinyemi202@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com,
shejialuo@gmail•com, johncai86@gmail•com,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [Outreachy][PATCH v2] builtin/update-server-info: remove the_repository global variable
Date: Tue, 11 Feb 2025 08:43:34 +0100 [thread overview]
Message-ID: <Z6r_pqqP5vjJI-R5@pks.im> (raw)
In-Reply-To: <20250210181103.3609495-1-usmanakinyemi202@gmail.com>
On Mon, Feb 10, 2025 at 11:40:30PM +0530, Usman Akinyemi wrote:
> Remove the_repository global variable in favor of the repository
> argument that gets passed in "builtin/update-server-info.c".
>
> When `-h` is passed to the command outside a Git repository, the
> `run_builtin()` will call the `cmd_update_server_info()` function
> with `repo` set to NULL and then early in the function, "parse_options()"
> call will give the options help and exit, without having to consult much
> of the configuration file. So it is safe to omit reading the config when
> `repo` argument the caller gave us is NULL.
Thanks, this version looks good to me.
Patrick
next prev parent reply other threads:[~2025-02-11 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 14:28 [Outreachy][PATCH] builtin/update-server-info: remove the_repository global variable Usman Akinyemi
2025-02-10 17:12 ` Junio C Hamano
2025-02-10 18:03 ` Usman Akinyemi
2025-02-10 18:10 ` [Outreachy][PATCH v2] " Usman Akinyemi
2025-02-11 7:43 ` Patrick Steinhardt [this message]
2025-02-11 16:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6r_pqqP5vjJI-R5@pks.im \
--to=ps@pks$(echo .)im \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johncai86@gmail$(echo .)com \
--cc=shejialuo@gmail$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox