Subject: Re: [GSoC PATCH v5 0/3] reftable: return proper error codes from block_writer_add

From: Patrick Steinhardt <[email-masked]>
Date: Wed, 19 Mar 2025 16:48:55 +0100

On Wed, Mar 19, 2025 at 08:59:24PM +0530, Meet Soni wrote:
> This patch series attempts to avoid making an assumption regarding error codes
> returned by block_writer_add().
> 
> Changes since v4:
>     - update commit message.
>     - add documentation comment.

One additional change that isn't mentioned here is that we now check for
REFTABLE_ENTRY_TOO_BIG_ERROR the second time we call
`block_writer_add()` when writing object records, which is what my only
concern was. So with that now addressed I'm happy with this patch
series, thanks for working on it!

Patrick