Subject: Re: [PATCH 1/5] t/lib-commit-graph.sh: allow `graph_read_expect()` in sub-directories

From: Taylor Blau <[email-masked]>
Date: Fri, 21 Jul 2023 14:33:46 -0400

On Fri, Jul 21, 2023 at 01:41:06PM -0400, Eric Sunshine wrote:
> > diff --git a/t/lib-commit-graph.sh b/t/lib-commit-graph.sh
> > @@ -32,6 +32,13 @@ graph_git_behavior() {
> >  graph_read_expect() {
> > +       DIR="."
> > +       if test "$1" = -C
> > +       then
> > +               shift
> > +               DIR="$1"
> > +               shift
> > +       fi
> > @@ -47,12 +54,15 @@ graph_read_expect() {
> > -       cat >expect <<- EOF
> > +       cat >$DIR/expect <<- EOF
>
> It may not matter for any of the current callers, but we'd normally
> want to quote the expansion of $DIR. Also, as I recall, some versions
> of bash complain if the target of '>' is not quoted. So:
>
>     cat >"$DIR/expect" <<-EOF

Hmm. I'm certainly happy to make this change, but there are many other
spots within our tests that would need similar updates. Looking through
the output of:

    $ git grep -E '>\$[[:alnum:]_]+/.*' -- t/**/*.sh

I see 25 such instances (including this one) that would need similar
treatment.

Thanks,
Taylor