Subject: Re: [PATCH v2 3/3] pkt-line: do not chomp newlines for sideband messages

From: Oswald Buddenhagen <[email-masked]>
Date: Tue, 26 Sep 2023 10:48:07 +0200

>Jiang Xin <[email-masked]> writes:
>
>> +++ b/pkt-line.c
>> @@ -462,8 +462,33 @@ enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
>>  	}
>> +			case 2:
>> +				/* fallthrough */
>> +			case 3:
>
while not entirely unprecedented, it's unnecessary and even 
counter-productive to annotate directly adjacent cases with fallthrough.

regards