Subject: Re: git diagnose with invalid CLI argument does not report error

From: Bagas Sanjaya <[email-masked]>
Date: Thu, 26 Oct 2023 18:10:13 +0700

On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> Hi Maintainers,
> 
> 
> Running git diagnose with an invalid CLI argument in a valid Git directory
> does not report error. Expected behaviour would be that it reports an error.
> 
> #Example shell commands which should have reported an error but continues to
> succeed
> 
> cd $ToAGitDirectory
> 
> git diagnose mod
> 
> git diagnose mode
> 
> git diagnose mode=all
> 

I can reproduce this only when the invalid parameter is a normal word:

```
$ git diagnose huh
```

But the command errors out on invalid flag:

```
$ git diagnose -m
```

Cc:'ing people who recently worked on builtin/diagnose.c for help.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara