From: Josh Steadmon <steadmon@google•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, delmerico@google•com
Subject: Re: sd/negotiate-trace-fix (was: What's cooking in git.git (Jan 2024, #06; Fri, 19))
Date: Tue, 23 Jan 2024 13:25:55 -0800 [thread overview]
Message-ID: <ZbAu49xkxEzJ3ZkX@google.com> (raw)
In-Reply-To: <xmqqbk9ghio5.fsf@gitster.g>
On 2024.01.19 17:56, Junio C Hamano wrote:
[snip]
> * sd/negotiate-trace-fix (2024-01-03) 1 commit
> - push: region_leave trace for negotiate_using_fetch
>
> Tracing fix.
>
> Waiting for a review response.
> cf. <xmqqbka27zu9.fsf@gitster•g>
> source: <20240103224054.1940209-1-delmerico@google•com>
Hi Junio,
Were there other open questions you had on this series? It looks like
Sam answered all the questions in your xmqqbka27zu9.fsf@gitster•g reply.
In your other followup you mentioned running CI with tracing enabled for
all tests. This is something that we suggested before [1] but it was
pretty thoroughly rejected for runtime reasons. Perhaps a more efficient
check for region_enter/leave pairs could be an option, though.
[1] https://lore.kernel.org/git/cover.1564009259.git.steadmon@google.com/
next prev parent reply other threads:[~2024-01-23 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 1:56 What's cooking in git.git (Jan 2024, #06; Fri, 19) Junio C Hamano
2024-01-20 2:10 ` Ghanshyam Thakkar
2024-01-20 17:19 ` Junio C Hamano
2024-01-23 8:23 ` ps/reftable-optimize-io (was: What's cooking in git.git (Jan 2024, #06; Fri, 19)) Patrick Steinhardt
2024-01-23 21:25 ` Josh Steadmon [this message]
2024-01-23 21:34 ` sd/negotiate-trace-fix Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbAu49xkxEzJ3ZkX@google.com \
--to=steadmon@google$(echo .)com \
--cc=delmerico@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox