Subject: Re: What's cooking in git.git (Feb 2024, #03; Tue, 6)

From: Kousik Sanagavarapu <[email-masked]>
Date: Wed, 7 Feb 2024 18:35:17 +0530

Hi,

Junio C Hamano <[email-masked]> wrote:

> * ak/color-decorate-symbols (2023-10-23) 7 commits
>  - log: add color.decorate.pseudoref config variable
>  - refs: exempt pseudorefs from pattern prefixing
>  - refs: add pseudorefs array and iteration functions
>  - log: add color.decorate.ref config variable
>  - log: add color.decorate.symbol config variable
>  - log: use designated inits for decoration_colors
>  - config: restructure color.decorate documentation
> 
>  A new config for coloring.
> 
>  Needs review.
>  source: <[email-masked]>

These commits have a design conflict [1] with the series

> * kn/for-all-refs (2024-01-29) 4 commits
>   (merged to 'next' on 2024-01-30 at e7a9234a8b)
>  + for-each-ref: avoid filtering on empty pattern
>  + refs: introduce `refs_for_each_all_refs()`
>  + refs: extract out `loose_fill_ref_dir_regular_file()`
>  + refs: introduce `is_pseudoref()` and `is_headref()`
> 
>  "git for-each-ref" filters its output with prefixes given from the
>  command line, but it did not honor an empty string to mean "pass
>  everything", which has been corrected.
> 
>  Reverted out of 'next' to revamp its UI.
>  source: <[email-masked]

So maybe change "Needs review" to "Not ready to be reviewed yet"? as
people who read it might not be aware that it is kind of an "out-dated"
(not surprising since it was sent last October) implementation and
reviewing needs to be held off till a reroll is sent.

Thanks

[1] I have detailed the conflict out here:

	https://lore.kernel.org/git/ZcEvLwp0t8-rcyGn@five231003/