Subject: Re: [PATCH 0/8] tightening ref handling outside of refs/

From: Patrick Steinhardt <[email-masked]>
Date: Mon, 29 Apr 2024 11:28:38 +0200

On Mon, Apr 29, 2024 at 04:42:38AM -0400, Jeff King wrote:
> On Mon, Apr 29, 2024 at 04:15:13AM -0400, Jeff King wrote:
> 
> >   [1/8]: t0600: don't create ref outside of refs/
> >   [2/8]: t5619: use fully qualified refname for branch
> 
> You can probably guess that I found these test cleanups only after
> writing the rest of the series and seeing them fail. :)
> 
> It turns out there is one more spot that is run only with reftables (so
> CI caught it, but my local testing did not):

Yeah, that's an issue by itself in my opinion. It's ultimately the
reason why I change this to always run the backend-specific tests in
[1].

> diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
> index 178791e086..c6dbd2b5c4 100755
> --- a/t/t0610-reftable-basics.sh
> +++ b/t/t0610-reftable-basics.sh
> @@ -343,11 +343,11 @@ test_expect_success 'ref transaction: env var disables compaction' '
>  	for i in $(test_seq $iterations)
>  	do
>  		GIT_TEST_REFTABLE_AUTOCOMPACTION=false \
> -		git -C repo update-ref branch-$i HEAD || return 1
> +		git -C repo update-ref refs/heads/branch-$i HEAD || return 1
>  	done &&
>  	test_line_count = $expected repo/.git/reftable/tables.list &&
>  
> -	git -C repo update-ref foo HEAD &&
> +	git -C repo update-ref refs/heads/foo HEAD &&
>  	test_line_count -lt $expected repo/.git/reftable/tables.list
>  '
>  
> I'll wait for comments before re-rolling, but I'll make sure that gets
> added in.

The fix looks reasonable.

Patrick

[1]: https://lore.kernel.org/git/[email-masked]/