Subject: Re: What's cooking in git.git (Jun 2024, #01; Mon, 3)

From: Patrick Steinhardt <[email-masked]>
Date: Tue, 4 Jun 2024 10:06:40 +0200

On Mon, Jun 03, 2024 at 11:16:11PM -0700, Junio C Hamano wrote:
> * jk/sparse-leakfix (2024-05-31) 14 commits
>  - sparse-checkout: free duplicate hashmap entries
>  - sparse-checkout: free string list after displaying
>  - sparse-checkout: free pattern list in sparse_checkout_list()
>  - sparse-checkout: free sparse_filename after use
>  - sparse-checkout: refactor temporary sparse_checkout_patterns
>  - sparse-checkout: always free "line" strbuf after reading input
>  - sparse-checkout: reuse --stdin buffer when reading patterns
>  - dir.c: always copy input to add_pattern()
>  - dir.c: free removed sparse-pattern hashmap entries
>  - sparse-checkout: clear patterns when init() sees existing sparse file
>  - dir.c: free strings in sparse cone pattern hashmaps
>  - sparse-checkout: pass string literals directly to add_pattern()
>  - sparse-checkout: free string list in write_cone_to_file()
>  - Merge branch 'jk/leakfixes' into jk/sparse-leakfix
>  (this branch uses jk/leakfixes and ps/leakfixes.)
> 
>  Many memory leaks in the sparse-checkout code paths have been
>  plugged.
> 
>  Will merge to 'next'?
>  source: <[email-masked]>

I've left a couple of comments on that patch series this morning.

> * ps/ref-storage-migration (2024-06-03) 14 commits
>  - builtin/refs: new command to migrate ref storage formats
>  - refs: implement logic to migrate between ref storage formats
>  - refs: implement removal of ref storages
>  - worktree: don't store main worktree twice
>  - reftable: inline `merged_table_release()`
>  - refs/files: fix NULL pointer deref when releasing ref store
>  - refs/files: extract function to iterate through root refs
>  - refs/files: refactor `add_pseudoref_and_head_entries()`
>  - refs: allow to skip creation of reflog entries
>  - refs: pass storage format to `ref_store_init()` explicitly
>  - refs: convert ref storage format to an enum
>  - setup: unset ref storage when reinitializing repository version
>  - Merge branch 'ps/pseudo-ref-terminology' into ps/ref-storage-migration
>  - Merge branch 'ps/refs-without-the-repository-updates' into ps/ref-storage-migration
> 
>  Allow migrating a repository that uses the files backend for its
>  ref storage to use the reftable backend, with limitations.
> 
>  Will merge to 'next'?
>  source: <[email-masked]>

This one is ready to go from my point of view.

Patrick