Subject: Re: [PATCH v3 09/20] global: introduce `USE_THE_REPOSITORY_VARIABLE` macro

From: Patrick Steinhardt <[email-masked]>
Date: Tue, 18 Jun 2024 07:16:39 +0200

On Mon, Jun 17, 2024 at 05:30:31AM -0400, Karthik Nayak wrote:
> Patrick Steinhardt <[email-masked]> writes:
> > diff --git a/hash.h b/hash.h
> > index 39a0164be3..cb85d26a2f 100644
> > --- a/hash.h
> > +++ b/hash.h
> > @@ -4,6 +4,8 @@
> >  #include "hash-ll.h"
> >  #include "repository.h"
> >
> > -#define the_hash_algo the_repository->hash_algo
> > +#ifdef USE_THE_REPOSITORY_VARIABLE
> > +# define the_hash_algo the_repository->hash_algo
> 
> s/# define/#define/

This is in fact intentional. We aren't strictly following this in our
codebase, but when nesting preprocessor macros into ifdefs then we often
indent the inner macros with spaces.

Patrick