Subject: Re: [PATCH 00/21] environment: guard reliance on `the_repository`

From: Patrick Steinhardt <[email-masked]>
Date: Fri, 30 Aug 2024 08:58:46 +0200

On Thu, Aug 29, 2024 at 12:59:35PM -0700, Junio C Hamano wrote:
> There may be more, but I know at least of these at the moment from
> https://github.com/git/git/actions/runs/10619536685/job/29437358521
> 
> Perhaps this can become [0.5/21] of the series, before globals are
> hidden behind the macro.

Thanks, I'll add these. I really need to spend some time to finally get
Win32 builds set up in GitLab CI.

Patrick

> --- >8 ---
> Subject: [PATCH] win32: mark the sources that depend on the_repository
> 
> These source files still need access to the global variables like
> "ignore_case" and "protect_ntfs".
> 
> Signed-off-by: Junio C Hamano <[email-masked]>
> ---
>  compat/mingw.c            | 2 ++
>  compat/win32/path-utils.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 29d3f09768..5c2080c04c 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -1,3 +1,5 @@
> +#define USE_THE_REPOSITORY_VARIABLE
> +
>  #include "../git-compat-util.h"
>  #include "win32.h"
>  #include <aclapi.h>
> diff --git a/compat/win32/path-utils.c b/compat/win32/path-utils.c
> index b658ca3f81..966ef779b9 100644
> --- a/compat/win32/path-utils.c
> +++ b/compat/win32/path-utils.c
> @@ -1,3 +1,5 @@
> +#define USE_THE_REPOSITORY_VARIABLE
> +
>  #include "../../git-compat-util.h"
>  #include "../../environment.h"
>  
> -- 
> 2.46.0-567-gbce23f156d
>