Subject: Re: [PATCH v7 00/14] Introduce clar testing framework

From: Patrick Steinhardt <[email-masked]>
Date: Wed, 4 Sep 2024 16:12:46 +0200

On Wed, Sep 04, 2024 at 02:35:33PM +0100, Phillip Wood wrote:
> Hi Patrick
> 
> On 03/09/2024 10:14, Patrick Steinhardt wrote:
> > Hi,
> > 
> > this is the seventh version fo my patch series that introduces the clar
> > unit testing framework.
> > 
> > Changes compared to v6:
> > 
> >    - Add some explanations for why we introduce clar in the first place
> >      to the second commit message.
> > 
> >    - Split out implementation of the test driver, that is the main
> >      function, into a separate commit.
> > 
> >    - Reimplement argument parsing ourselves. This allows more flexibility
> >      and gets rid of some options that do not make sense for us.
> > 
> >    - Add an empty line between declarations and code.
> > 
> >    - Improve the test messages in ctype tests to also mention our
> >      expectations.
> > 
> >    - Adapt `cl_failf()` to not use `xstrfmt()`, but `snprintf()` with a
> >      static buffer instead.
> 
> I've left some comments on patch 11 which is new. Apart from that range-diff
> looks fine to me.
> 
> Thanks for working on this
> 
> Phillip

Thanks for all your reviews on this series, highly appreciated!

Patrick