Subject: Re: What's cooking in git.git (Sep 2024, #01; Thu, 5)

From: Patrick Steinhardt <[email-masked]>
Date: Fri, 6 Sep 2024 11:18:03 +0200

On Thu, Sep 05, 2024 at 04:01:12PM -0700, Junio C Hamano wrote:
> * ps/leakfixes-part-6 (2024-09-05) 22 commits
>  - builtin/repack: fix leaking keep-pack list
>  - merge-ort: fix two leaks when handling directory rename modifications
>  - match-trees: fix leaking prefixes in `shift_tree()`
>  - builtin/fmt-merge-msg: fix leaking buffers
>  - builtin/grep: fix leaking object context
>  - builtin/pack-objects: plug leaking list of keep-packs
>  - builtin/repack: fix leaking line buffer when packing promisors
>  - negotiator/skipping: fix leaking commit entries
>  - shallow: fix leaking members of `struct shallow_info`
>  - shallow: free grafts when unregistering them
>  - object: clear grafts when clearing parsed object pool
>  - gpg-interface: fix misdesigned signing key interfaces
>  - send-pack: fix leaking push cert nonce
>  - remote: fix leak in reachability check of a remote-tracking ref
>  - remote: fix leaking tracking refs
>  - builtin/submodule--helper: fix leaking refs on push-check
>  - submodule: fix leaking fetch task data
>  - upload-pack: fix leaking child process data on reachability checks
>  - builtin/push: fix leaking refspec query result
>  - send-pack: fix leaking common object IDs
>  - fetch-pack: fix memory leaks on fetch negotiation
>  - t/test-lib: allow skipping leak checks for passing tests
> 
>  More leakfixes.
> 
>  Will merge to 'next'?
>  source: <[email-masked]>

There were multiple ACKs on the first version, and the second version
only addressed some feedback for trivial things. So I think this one
should be ready.

> * sj/ref-contents-check (2024-09-03) 4 commits
>  - ref: add symlink ref content check for files backend
>  - ref: add symref content check for files backend
>  - ref: add regular ref content check for files backend
>  - ref: initialize "fsck_ref_report" with zero
> 
>  "git fsck" learned to issue warnings on "curiously formatted" ref
>  contents that have always been taken valid but something Git
>  wouldn't have written itself (e.g., missing terminating end-of-line
>  after the full object name).
> 
>  Ready?
>  source: <Ztb-mgl50cwGVO8A@ArchLinux>

I'll do another review soonish, either today or on Monday.

Patrick