Subject: Re: [PATCH v4 25/25] reftable/basics: ban standard allocator functions

From: Patrick Steinhardt <[email-masked]>
Date: Wed, 2 Oct 2024 06:30:48 +0200

On Tue, Oct 01, 2024 at 03:50:42PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <[email-masked]> writes:
> 
> > +#ifndef REFTABLE_ALLOW_BANNED_ALLOCATORS
> > +# define REFTABLE_BANNED(func) use_reftable_##func##_instead
> 
> We'd need to mimic banned.h a bit better, by adding
> 
> #undef malloc
> #undef realloc
> #undef free
> #undef calloc
> #undef strdup
> 
> before (potentially re-)defining them.
> 
> > +# define malloc(sz) REFTABLE_BANNED(malloc)
> > +# define realloc(ptr, sz) REFTABLE_BANNED(realloc)
> > +# define free(ptr) REFTABLE_BANNED(free)
> > +# define calloc(nelem, elsize) REFTABLE_BANNED(calloc)
> > +# define strdup(str) REFTABLE_BANNED(strdup)
> > +#endif

Oh, indeed, that's something I missed. Will do for a hopefully last
reroll.

Patrick