Subject: Re: [PATCH] t: fix typos

From: Andrew Kreimer <[email-masked]>
Date: Fri, 18 Oct 2024 19:51:32 +0300

On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:
> Please do not base new topics on 'seen', as it is likely to change
> day-to-day.
> 

Noted, thank you.

> > @@ -117,7 +117,7 @@ do
> >  		git config extensions.objectformat $hash &&
> >  		git config extensions.compatobjectformat $(compat_hash $hash) &&
> >  		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > -		echo "Hellow World!" > hello &&
> > +		echo "Hello World!" > hello &&
> 
> Not the fault of this patch, but there is a style issue here that there
> should not be a space between '>' and 'hello' (i.e. it should read
> '>hello', not '> hello').
> 

Do you mean that '> more' and '> another' should be handled similarly?

> Likewise with the 'git config' use above should be test_config, etc. But
> this patch does not need to care about that, since it did not introduce
> those issues in the first place.
> 

Will try to address this one.