Subject: Re: [PATCH] t1016: clean up style

From: Taylor Blau <[email-masked]>
Date: Mon, 21 Oct 2024 17:48:05 -0400

On Mon, Oct 21, 2024 at 05:45:56PM -0400, Taylor Blau wrote:
> On Sun, Oct 20, 2024 at 02:46:18PM +0200, Kristoffer Haugsbakk wrote:
> > Hi
> >
> > On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:
> > > Use `test_config`.
> > >
> > > Remove whitespace after redirect operator.
> > >
> > > Reported-by: Taylor Blau <[email-masked]>
> > > Signed-off-by: Andrew Kreimer <[email-masked]>
> > > ---
> > > As discussed in:
> > >   - https://lore.kernel.org/git/[email-masked]/
> > > […]
> > > -		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > > -		echo "Hellow World!" > hello &&
> > > +		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > > +		echo "Hellow World!" >hello &&
> >
> > What Taylor wrote:
> >
> > > Thanks, both. [Andrew] -- it's fine to do this in the same, or a
> > > separate patch in the new round. Thanks.
> >
> > You’ve posted a new, standalone patch.  But what Taylor asked for was a
> > new round on that typo patch where you either squash these changes into
> > the original patch or have the typo patch plus this one.
> >
> > At least that’s how I understand it.
>
> I said originally that either was fine, but then revised my statement
> after remembering that the original topic was already in 'next', so any
> further changes would have to be done on top.

...but after queueing, this patch does not apply cleanly on ak/typofix,
which is what this patch should be based on AFAICT.

Andrew, would you please send a version based on the aforementioned
topic?

Thanks,
Taylor