Subject: Re: [PATCH 7/8] midx: pass down `hash_algo` to `get_split_midx_filename_ext`

From: shejialuo <[email-masked]>
Date: Sat, 16 Nov 2024 21:20:19 +0800

On Fri, Nov 15, 2024 at 02:42:20PM +0100, Karthik Nayak wrote:

[snip]

> diff --git a/midx.h b/midx.h
> index 7620820d4d0272926af9e4eeb68bfb73404c7ec2..9d1374cbd58d016bb82338337b2a4e5ba7234092 100644
> --- a/midx.h
> +++ b/midx.h
> @@ -97,7 +97,8 @@ void get_midx_filename_ext(const struct git_hash_algo *hash_algo,
>  			   const unsigned char *hash, const char *ext);
>  void get_midx_chain_dirname(struct strbuf *buf, const char *object_dir);
>  void get_midx_chain_filename(struct strbuf *buf, const char *object_dir);
> -void get_split_midx_filename_ext(struct strbuf *buf, const char *object_dir,
> +void get_split_midx_filename_ext(const struct git_hash_algo *hash_algo,
> +				 struct strbuf *buf, const char *object_dir,

Similar to comment for the previous patch, we should not put "hash_algo"
at the first.

>  				 const unsigned char *hash, const char *ext);
>  
>  struct multi_pack_index *load_multi_pack_index(struct repository *r,
> 
> -- 
> 2.47.0
>