public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Samo Pogačnik" <samo_pogacnik@t-2•net>
To: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Cc: Patrick Steinhardt <ps@pks•im>, Taylor Blau <me@ttaylorr•com>,
	Johannes Schindelin <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH v2] shallow: set borders which are all reachable after clone shallow since
Date: Sat, 07 Feb 2026 06:06:01 +0100	[thread overview]
Message-ID: <a60fc6aed8ab7345219118f933ac0eb61140334f.camel@t-2.net> (raw)
In-Reply-To: <3253600a3c96144744d3371a7ec2a66cb87d4b60.camel@t-2.net>

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

On Wed, 2026-01-28 at 05:23 +0100, Samo Pogačnik wrote:
> On Tue, 2026-01-20 at 12:59 -0800, Junio C Hamano wrote:
> > Junio C Hamano <gitster@pobox•com> writes:
> > 
> > > > ...
> > > > The modified implementation of a generic shallow boundary finder
> > > > based on rev-list ensures that all shallow border commits are reachable
> > > > also after being grafted. This is achieved by inspecting all parents
> > > > of each initial border commit candidate. The border commit candidate
> > > > is set border only when all its parents wern't on the initial list of
> > > > candidates. Otherwise the border commit candidate is not set as border
> > > > however its parents that weren't on the list of candidates are set as
> > > > borders.
> > > 
> > > It is a minor point, but there are "boundary" and "border" used more
> > > or less interchangeably in the proposed commit log message, and
> > > would make the readers wonder if there are differences (I do not
> > > think we use the word "border" anywhere in our documentation).  It
> > > is minor as we do not have such mixture in the end-user facing part
> > > of the documentation with this patch.
> > > 
> > > I'll let those (cc'ed) who may be more familiar with, or, at least
> > > have more code than I have in, the shallow infrastructure to comment
> > > on the way the updated code uses the revision machinery.
> > 
> > After this exchange, the topic has been dormant for almost full two
> > months.  As I do not deal with shallow clones myself, even though I
> > understand that some folks rely on it working, I'd really prefer to
> > see somebody who are familiar with the underlying logic to review
> > this patch if we were to move forward with it.
> > 
> 
> I’m currently rewriting the patch and the commit message trying to
> address the boundary/border dilemma. I hope to be able to send a new
> version by the end of this week.
> 

I posted a new version of patch '[PATCH v3] shallow: ensure all boundary commits
are reachable with --shallow-since' on 31st of January. I hope you've seen it.

thanks, Samo

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

next prev parent reply	other threads:[~2026-02-07  5:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22 10:38 [PATCH] Fixed --shallow-since generating descendant borders Samo Pogačnik via GitGitGadget
2025-11-22 17:36 ` Junio C Hamano
2025-11-23 19:35 ` [PATCH v2] shallow: set borders which are all reachable after clone shallow since Samo Pogačnik via GitGitGadget
2025-11-25  0:43   ` Junio C Hamano
2026-01-20 20:59     ` Junio C Hamano
2026-01-28  4:23       ` Samo Pogačnik
2026-02-07  5:06         ` Samo Pogačnik [this message]
2026-02-07  5:19           ` Junio C Hamano
2026-03-07  7:13             ` Samo Pogačnik
2026-01-31 16:28   ` [PATCH v3] shallow: ensure all boundary commits are reachable with --shallow-since Samo Pogačnik via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a60fc6aed8ab7345219118f933ac0eb61140334f.camel@t-2.net \
    --to=samo_pogacnik@t-2$(echo .)net \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=me@ttaylorr$(echo .)com \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox