From: Todd Zullinger <tmz@pobox•com>
To: phillip.wood@dunelm•org.uk
Cc: Patrick Steinhardt <ps@pks•im>,
Junio C Hamano <gitster@pobox•com>,
Ramsay Jones <ramsay@ramsayjones•plus.com>,
git@vger•kernel.org, Eli Schwartz <eschwartz@gentoo•org>
Subject: Re: [PATCH 0/4] meson: parse TAP output generated by our tests
Date: Mon, 26 May 2025 10:23:04 -0400 [thread overview]
Message-ID: <aDR5SDrrOEpNFhvv@teonanacatl.net> (raw)
In-Reply-To: <74c03ad4-b132-4cad-b65d-821324380343@gmail.com>
Phillip Wood wrote:
> On 26/05/2025 13:44, Patrick Steinhardt wrote:
>>
>> I don't think it's inherently a bad thing to fail on unexpected passes.
>> After all, it shows that our assumption that the test fails is broken,
>> and that we should have a look why that is. But I can see arguments both
>> ways.
>
> Personally I'd be very happy if our test suite failed on an unexpected pass.
> Currently it is easy to miss, especially if the unexpected pass occurs in a
> CI run. Missing an unexpected pass means we don't change
> 'test_expect_failure' to 'test_expect_pass' and a future regression that
> causes the test to fail again will go unnoticed.
Indeed. Perhaps related (apologies if it's a wild tangent),
having a way to expose an unexpectedly failed prereq would
be nice.
For example, we currently (well, last time I checked, which
was a month or so ago) fail the GPG2 prereq. I submitted
small patch series to fix that nearly a year ago¹, but when
I ran the tests in our CI, they turned up some preexisting
failures.
I spent a little time trying to reproduce and resolve the
failures, but was never able to make it work. These tests
pass when run locally which makes it painful to track down.
It would have been ideal if they failed when added, so that
it could have been worked out during the review period,
while it was fresh in the minds of the folks working in that
area.
We are simply not noticing these failures in our CI, which
feels worse than simply not having test coverage. It gives
a false of security that t/t1016-compatObjectFormat.sh is
passing. In reality, the tests might be reporting a real
issue that we've been missing for ages.
¹ <20240703153738.916469-1-tmz@pobox•com>
--
Todd
next prev parent reply other threads:[~2025-05-26 14:23 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 10:59 [PATCH 0/4] meson: parse TAP output generated by our tests Patrick Steinhardt
2025-05-06 10:59 ` [PATCH 1/4] t: fix cases where output breaks TAP format Patrick Steinhardt
2025-05-06 13:17 ` Phillip Wood
2025-05-07 6:52 ` Patrick Steinhardt
2025-05-07 10:12 ` Phillip Wood
2025-05-14 18:51 ` Karthik Nayak
2025-05-06 10:59 ` [PATCH 2/4] t/test-lib: don't print shell traces to stdout Patrick Steinhardt
2025-05-06 10:59 ` [PATCH 3/4] meson: introduce kwargs variable for tests Patrick Steinhardt
2025-05-15 7:39 ` Karthik Nayak
2025-05-06 10:59 ` [PATCH 4/4] meson: parse TAP output generated by our tests Patrick Steinhardt
2025-05-15 7:48 ` Karthik Nayak
2025-05-15 8:20 ` Patrick Steinhardt
2025-05-15 11:35 ` Karthik Nayak
2025-05-06 12:29 ` [PATCH 0/4] " Patrick Steinhardt
2025-05-07 7:06 ` Patrick Steinhardt
2025-05-21 10:57 ` Patrick Steinhardt
2025-05-21 11:56 ` Hridoy Ahmed
2025-05-21 16:06 ` Junio C Hamano
2025-05-21 21:26 ` Junio C Hamano
2025-05-23 10:03 ` Patrick Steinhardt
2025-05-23 15:00 ` Patrick Steinhardt
2025-05-23 15:58 ` Junio C Hamano
2025-05-23 16:40 ` Ramsay Jones
2025-05-23 16:53 ` Ramsay Jones
2025-05-23 19:33 ` Junio C Hamano
2025-05-26 12:44 ` Patrick Steinhardt
2025-05-26 13:31 ` Phillip Wood
2025-05-26 14:23 ` Todd Zullinger [this message]
2025-05-26 13:54 ` Eli Schwartz
2025-05-26 13:59 ` Patrick Steinhardt
2025-05-27 16:04 ` Junio C Hamano
2025-05-28 12:27 ` Patrick Steinhardt
2025-05-27 13:36 ` Junio C Hamano
2025-05-27 14:02 ` [PATCH v2 0/6] " Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 1/6] t: fix cases where output breaks TAP format Patrick Steinhardt
2025-05-27 19:47 ` Eric Sunshine
2025-05-28 15:55 ` Patrick Steinhardt
2025-05-28 20:14 ` Eric Sunshine
2025-05-30 7:50 ` Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 2/6] t/test-lib: don't print shell traces to stdout Patrick Steinhardt
2025-05-27 19:47 ` Junio C Hamano
2025-05-28 15:55 ` Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 3/6] t/test-lib: fix TAP format for BASH_XTRACEFD warning Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 4/6] t7815: fix unexpectedly passing test on macOS Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 5/6] meson: introduce kwargs variable for tests Patrick Steinhardt
2025-05-27 14:02 ` [PATCH v2 6/6] meson: parse TAP output generated by our tests Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 00/10] " Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 01/10] t: stop announcing prereqs Patrick Steinhardt
2025-05-31 21:00 ` Karthik Nayak
2025-05-30 13:31 ` [PATCH v3 02/10] t: silence output from `test_create_repo()` Patrick Steinhardt
2025-05-30 21:16 ` Eric Sunshine
2025-05-30 13:31 ` [PATCH v3 03/10] t9822: use prereq to check for ISO-8859-1 support Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 04/10] t983*: use prereq to check for Python-specific git-b4(1) support Patrick Steinhardt
2025-05-30 14:08 ` Todd Zullinger
2025-05-30 14:21 ` Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 05/10] t/test-lib: don't print shell traces to stdout Patrick Steinhardt
2025-05-31 21:21 ` Karthik Nayak
2025-05-30 13:31 ` [PATCH v3 06/10] t/test-lib: fix TAP format for BASH_XTRACEFD warning Patrick Steinhardt
2025-05-31 21:25 ` Karthik Nayak
2025-05-30 13:31 ` [PATCH v3 07/10] t7815: fix unexpectedly passing test on macOS Patrick Steinhardt
2025-05-31 21:28 ` Karthik Nayak
2025-06-01 9:19 ` Kristoffer Haugsbakk
2025-06-02 6:19 ` Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 08/10] test-lib: fail on unexpectedly passing tests Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 09/10] meson: introduce kwargs variable for tests Patrick Steinhardt
2025-05-30 13:31 ` [PATCH v3 10/10] meson: parse TAP output generated by our tests Patrick Steinhardt
2025-05-31 21:37 ` [PATCH v3 00/10] " Karthik Nayak
2025-06-02 6:44 ` [PATCH v4 " Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 01/10] t: stop announcing prereqs Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 02/10] t: silence output from `test_create_repo()` Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 03/10] t9822: use prereq to check for ISO-8859-1 support Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 04/10] t983*: use prereq to check for Python-specific git-p4(1) support Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 05/10] t/test-lib: don't print shell traces to stdout Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 06/10] t/test-lib: fix TAP format for BASH_XTRACEFD warning Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 07/10] t7815: fix unexpectedly passing test on macOS Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 08/10] test-lib: fail on unexpectedly passing tests Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 09/10] meson: introduce kwargs variable for tests Patrick Steinhardt
2025-06-02 6:44 ` [PATCH v4 10/10] meson: parse TAP output generated by our tests Patrick Steinhardt
2025-06-02 7:40 ` [PATCH v4 00/10] " Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDR5SDrrOEpNFhvv@teonanacatl.net \
--to=tmz@pobox$(echo .)com \
--cc=eschwartz@gentoo$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
--cc=ramsay@ramsayjones$(echo .)plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox