From: Patrick Steinhardt <ps@pks•im>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [GSoC PATCH 2/2] MyFirstContribution: add walken.c to meson.build
Date: Fri, 30 May 2025 10:00:52 +0200 [thread overview]
Message-ID: <aDlltNOH5pWBbwTQ@pks.im> (raw)
In-Reply-To: <20250529192036.75408-3-lucasseikioshiro@gmail.com>
On Thu, May 29, 2025 at 04:20:36PM -0300, Lucas Seiki Oshiro wrote:
> diff --git a/Documentation/MyFirstObjectWalk.adoc b/Documentation/MyFirstObjectWalk.adoc
> index 29d26abb47..3b66e48dd9 100644
> --- a/Documentation/MyFirstObjectWalk.adoc
> +++ b/Documentation/MyFirstObjectWalk.adoc
> @@ -96,12 +96,19 @@ maintaining alphabetical ordering:
> { "walken", cmd_walken, RUN_SETUP },
> ----
>
> -Add it to the `Makefile` near the line for `builtin/worktree.o`:
> +Add an entry for the new command in the file of our two build systems (Make
> +and Meson) before the entry for `worktree`:
>
> +- In the `Makefile`:
> ----
> BUILTIN_OBJS += builtin/walken.o
> ----
>
> +- In the `meson.build` file:
> +----
> + 'builtin/walken.c',
> +----
It's a bit hard for the reader to know _where_ to add this. How about we
say this instead:
----
builtin_sources = [
...
'builtin/walken.c',
...
]
----
That should make it was easier to figure out.
Patrick
next prev parent reply other threads:[~2025-05-30 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:20 [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Lucas Seiki Oshiro
2025-05-29 19:20 ` [GSoC PATCH 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-05-29 19:57 ` Karthik Nayak
2025-05-29 19:20 ` [GSoC PATCH 2/2] MyFirstContribution: add walken.c to meson.build Lucas Seiki Oshiro
2025-05-29 20:02 ` Karthik Nayak
2025-05-30 8:00 ` Patrick Steinhardt [this message]
2025-05-29 20:06 ` [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Karthik Nayak
2025-06-02 20:50 ` [GSoC PATCH v2 0/2] MyFirstObjectWalk: update " Lucas Seiki Oshiro
2025-06-02 20:50 ` [GSoC PATCH v2 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-06-02 20:50 ` [GSoC PATCH v2 2/2] MyFirstContribution: add walken.c to meson.build Lucas Seiki Oshiro
2025-06-03 6:08 ` [GSoC PATCH v2 0/2] MyFirstObjectWalk: update with struct repository and meson Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDlltNOH5pWBbwTQ@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=lucasseikioshiro@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox