From: Patrick Steinhardt <ps@pks•im>
To: Junio C Hamano <gitster@pobox•com>
Cc: redoste <redoste@redoste•xyz>,
git@vger•kernel.org, Jeff King <peff@peff•net>,
"brian m. carlson" <sandals@crustytoothpaste•net>,
Phillip Wood <phillip.wood@dunelm•org.uk>,
Elijah Newren <newren@gmail•com>,
Fabian Stelzer <fs@gigacodes•de>
Subject: Re: [PATCH v3] ssh signing: don't detach the filename strbuf from key_file tempfile
Date: Tue, 8 Jul 2025 08:47:40 +0200 [thread overview]
Message-ID: <aGy_DEehFgw4A6va@pks.im> (raw)
In-Reply-To: <xmqq4ivn4t30.fsf@gitster.g>
On Mon, Jul 07, 2025 at 01:57:39PM -0700, Junio C Hamano wrote:
> redoste <redoste@redoste•xyz> writes:
>
> > v2->v3:
> > * merge the test with the previous ssh-agent test
> > * export TMPDIR in a subshell to prevent the environment variable from
> > leaking in the next tests
> > * use test_must_be_empty instead of test_line_count
>
> These sound all good. Will queue.
Yup, the patch looks good to me. Thanks!
Patrick
next prev parent reply other threads:[~2025-07-08 6:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 23:08 [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile redoste
2025-07-05 19:21 ` Jeff King
2025-07-05 20:07 ` brian m. carlson
2025-07-05 22:50 ` redoste
2025-07-05 23:04 ` redoste
2025-07-06 0:28 ` brian m. carlson
2025-07-06 3:13 ` Jeff King
2025-07-06 17:20 ` redoste
2025-07-06 17:14 ` redoste
2025-07-06 17:34 ` [PATCH v2] " redoste
2025-07-06 21:21 ` brian m. carlson
2025-07-07 9:02 ` Patrick Steinhardt
2025-07-07 9:35 ` Phillip Wood
2025-07-07 14:25 ` redoste
2025-07-07 15:26 ` Phillip Wood
2025-07-07 16:22 ` redoste
2025-07-07 16:42 ` Phillip Wood
2025-07-07 18:48 ` [PATCH v3] " redoste
2025-07-07 20:57 ` Junio C Hamano
2025-07-08 6:47 ` Patrick Steinhardt [this message]
2025-07-08 13:59 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGy_DEehFgw4A6va@pks.im \
--to=ps@pks$(echo .)im \
--cc=fs@gigacodes$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=redoste@redoste$(echo .)xyz \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox