Subject: Re: [PATCH v5 00/10] t/unit-tests: convert unit-tests to use clar

From: Patrick Steinhardt <[email-masked]>
Date: Thu, 24 Jul 2025 16:41:56 +0200

On Thu, Jul 24, 2025 at 03:28:27PM +0100, Seyi Kufoiji wrote:
> Range-diff against v4:
>  -:  ---------- >  1:  4a04557ae3 t/unit-tests: implement clar specific reftable test helper functions
>  -:  ---------- >  2:  2c576ddd11 t/unit-tests: convert reftable basics test to use clar test framework
>  -:  ---------- >  3:  04d54fef89 t/unit-tests: convert reftable block test to use clar
>  -:  ---------- >  4:  06eba27f8e t/unit-tests: convert reftable merged test to use clar
>  -:  ---------- >  5:  eaa8b8d636 t/unit-tests: convert reftable pq test to use clar

Something here went wrong. :) But the remainder of the range-diff looks
exactly like I'd expect it to:

  - The Meson change gets moved to the correct commit.

  - The missing newline got fixed up.

Thanks!

Patrick

>  1:  7c159bd2fe !  6:  cf8b0471fd t/unit-tests: convert reftable table test to use clar
>     @@ Makefile: CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable-clar.o
>       UNIT_TEST_PROGS = $(patsubst %,$(UNIT_TEST_BIN)/%$X,$(UNIT_TEST_PROGRAMS))
>       UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o
>       UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o
>     -@@ Makefile: $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
>     - 	$(OBJCOPY) --localize-hidden $^ $@
>     - 
>     - contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
>     --	$(AR) $(ARFLAGS) $@ $^
>     -+	$(AR) $(ARFLAGS) $@ $^
>     - \ No newline at end of file
>      
>       ## t/meson.build ##
>      @@ t/meson.build: clar_test_suites = [
>  2:  3ae3b2cf9c =  7:  cbe70c5c23 t/unit-tests: convert reftable readwrite test to use clar
>  3:  d4303eb913 !  8:  38e2198eac t/unit-tests: convert reftable record test to use clar
>     @@ Makefile: CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o
>       UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o
>      
>       ## t/meson.build ##
>     +@@ t/meson.build: clar_test_suites = [
>     +   'unit-tests/u-reftable-merged.c',
>     +   'unit-tests/u-reftable-pq.c',
>     +   'unit-tests/u-reftable-readwrite.c',
>     ++  'unit-tests/u-reftable-record.c',
>     +   'unit-tests/u-reftable-table.c',
>     +   'unit-tests/u-reftable-tree.c',
>     +   'unit-tests/u-strbuf.c',
>      @@ t/meson.build: clar_unit_tests = executable('unit-tests',
>       test('unit-tests', clar_unit_tests)
>       
>  4:  df582f6e2c !  9:  8de9dbbd3b t/unit-tests: convert reftable stack test to use clar
>     @@ Makefile: CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o
>      
>       ## t/meson.build ##
>      @@ t/meson.build: clar_test_suites = [
>     -   'unit-tests/u-reftable-merged.c',
>         'unit-tests/u-reftable-pq.c',
>         'unit-tests/u-reftable-readwrite.c',
>     -+  'unit-tests/u-reftable-record.c',
>     +   'unit-tests/u-reftable-record.c',
>      +  'unit-tests/u-reftable-stack.c',
>         'unit-tests/u-reftable-table.c',
>         'unit-tests/u-reftable-tree.c',
>  5:  9340e7ce88 ! 10:  a69c3370ee t/unit-tests: finalize migration of reftable-related tests
>     @@ Makefile: CLAR_TEST_SUITES += u-urlmatch-normalization
>       
>       # xdiff and reftable libs may in turn depend on what is in libgit.a
>       GITLIBS = common-main.o $(LIB_FILE) $(XDIFF_LIB) $(REFTABLE_LIB) $(LIB_FILE)
>     -@@ Makefile: $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
>     - 	$(OBJCOPY) --localize-hidden $^ $@
>     - 
>     - contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
>     --	$(AR) $(ARFLAGS) $@ $^
>     - \ No newline at end of file
>     -+	$(AR) $(ARFLAGS) $@ $^
>      
>       ## t/Makefile ##
>      @@ t/Makefile: check-meson:
> -- 
> 2.43.0
>