From: Patrick Steinhardt <ps@pks•im>
To: "Osipov, Michael (IN IT IN)" <michael.osipov@innomotics•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [Bug] Compat objects not added to CLAR_TEST_PROG
Date: Tue, 9 Sep 2025 12:15:15 +0200 [thread overview]
Message-ID: <aL_-My5lxRQiOPmh@pks.im> (raw)
In-Reply-To: <50da35ac-71f8-49dd-bcd8-83726f1954a9@innomotics.com>
On Tue, Sep 09, 2025 at 10:00:54AM +0200, Osipov, Michael (IN IT IN) wrote:
> On 2025-09-09 09:45, Patrick Steinhardt wrote:
> > diff --git a/clar/sandbox.h b/clar/sandbox.h
> > index ff43159..5af36f3 100644
> > --- a/clar/sandbox.h
> > +++ b/clar/sandbox.h
> > @@ -164,7 +164,7 @@ static int build_tempdir_path(void)
> > if (mkdir(_clar_tempdir, 0700) != 0)
> > return -1;
> > -#elif defined(__sun) || defined(__TANDEM)
> > +#elif defined(__sun) || defined(__TANDEM) || defined(__HPUX)
> > if (mktemp(_clar_tempdir) == NULL)
> > return -1;
> > The `__HPUX` define is pulled out of thin air, I have no idea what
> > preprocessor macro that system sets. But something in that spirit may
> > fix that issue. If so, I'm happy to fix this upstream and then pull
> > the latest version into Git.
>
> I can confirm that your idea works and much better than my idea:
> root@deblndw002x:/var/tmp/ports/work
> # diff -ur git-2.51.0 git-2.51.0.patched/ | grep -v "Only in"
> diff -u -ur git-2.51.0/t/unit-tests/clar/clar/sandbox.h
> git-2.51.0.patched/t/unit-tests/clar/clar/sandbox.h
> --- git-2.51.0/t/unit-tests/clar/clar/sandbox.h 2025-08-18 02:35:38 +0200
> +++ git-2.51.0.patched/t/unit-tests/clar/clar/sandbox.h 2025-09-09 09:50:07
> +0200
> @@ -128,7 +128,7 @@
>
> if (mkdir(_clar_path, 0700) != 0)
> return -1;
> -#elif defined(__sun) || defined(__TANDEM)
> +#elif defined(__sun) || defined(__TANDEM) || defined(__hpux)
> if (mktemp(_clar_path) == NULL)
> return -1;
>
> Can you make that happen upstream?
Merged upstream now via [1]. I'll send a patch to the mailing list later
today to bring us to the latest version.
Patrick
[1]: https://github.com/clar-test/clar/pull/120
next prev parent reply other threads:[~2025-09-09 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:19 [Bug] Compat objects not added to CLAR_TEST_PROG Osipov, Michael (IN IT IN)
2025-09-05 21:37 ` Jeff King
2025-09-05 22:12 ` Osipov, Michael (IN IT IN)
2025-09-09 7:45 ` Patrick Steinhardt
2025-09-09 8:00 ` Osipov, Michael (IN IT IN)
2025-09-09 10:15 ` Patrick Steinhardt [this message]
2025-09-09 12:07 ` Osipov, Michael (IN IT IN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL_-My5lxRQiOPmh@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=michael.osipov@innomotics$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox