From: Patrick Steinhardt <ps@pks•im>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, jltobler@gmail•com
Subject: Re: [PATCH v2 0/3] refs: cleanup code around optimizations
Date: Tue, 21 Oct 2025 07:16:36 +0200 [thread overview]
Message-ID: <aPcXNOz7HdxfUzcC@pks.im> (raw)
In-Reply-To: <20251020-refs-code-cleanup-v2-0-f5349ed0f6a5@gmail.com>
On Mon, Oct 20, 2025 at 10:18:28AM +0200, Karthik Nayak wrote:
> This is extracted from a recent series I sent [1], which I've since
> dropped to follow up with a different approach. I think these patches
> hold value individually.
>
> They mostly cleanup code around 'git refs optimize' which was added
> recently in db0babf9b2 (Merge branch 'ms/refs-optimize', 2025-10-02).
> The code in the refs subsystem contains both 'pack-refs' and 'optimize'
> functions, which are one and the same.
>
> This series unifies this to only retain the 'optimize' functions and
> naming, since it backend generic.
>
> This is based on top of master 143f58ef75 (Sync with Git 2.51.1,
> 2025-10-15) with 'ps/ref-peeled-tags' merged in.
>
> [1]: 20251010-562-add-option-to-check-if-reference-backend-needs-repacking-v1-0-c7962be584fa@gmail•com
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail•com>
> ---
> Changes in v2:
> - Squash the second commit into the first.
> - Change some variable names to also no longer refer to pack_refs.
> - Fix commit messages.
> - Link to v1: https://lore.kernel.org/r/20251015-refs-code-cleanup-v1-0-550fdd8a3b41@gmail.com
This version looks good to me. Thanks for all these cleanups!
Patrick
next prev parent reply other threads:[~2025-10-21 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 8:18 [PATCH v2 0/3] refs: cleanup code around optimizations Karthik Nayak
2025-10-20 8:18 ` [PATCH v2 1/3] refs: move to using the '.optimize' functions Karthik Nayak
2025-10-20 8:18 ` [PATCH v2 2/3] refs: rename 'pack_refs_opts' to 'refs_optimize_opts' Karthik Nayak
2025-10-20 8:18 ` [PATCH v2 3/3] t/pack-refs-tests: move the 'test_done' to callees Karthik Nayak
2025-10-21 5:16 ` Patrick Steinhardt [this message]
2025-10-22 11:59 ` [PATCH v2 0/3] refs: cleanup code around optimizations Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPcXNOz7HdxfUzcC@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=jltobler@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox