On 2025-10-29 at 16:32:50, Junio C Hamano wrote: > "brian m. carlson" writes: > > > +struct git_hash_ctx *git_hash_alloc(void) > > +{ > > + return malloc(sizeof(struct git_hash_ctx)); > > +} > > Not an objection, but this looked especially curious to me because > it has been customary to use xmalloc() for a thing like this. Going > forward, is our intention that we'd explicitly handle OOM allocation > failures ourselves, at least in the Rust part of the code base? No, I'll change this to use `xmalloc`. Rust handles allocation itself and just panics on OOM, so we will not want to handle allocation failures ourselves. -- brian m. carlson (they/them) Toronto, Ontario, CA