From: Patrick Steinhardt <ps@pks•im>
To: Junio C Hamano <gitster@pobox•com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH] make strip: include `scalar`
Date: Mon, 1 Dec 2025 08:58:34 +0100 [thread overview]
Message-ID: <aS1KqrTRxHSGDDZY@pks.im> (raw)
In-Reply-To: <xmqq4iqhraem.fsf@gitster.g>
On Tue, Nov 25, 2025 at 02:54:09PM -0800, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
>
> >> > -strip: $(PROGRAMS) git$X
> >> > +strip: $(PROGRAMS) git$X scalar$X
> >> > $(STRIP) $(STRIP_OPTS) $^
> >>
> >> I wonder why the original names git$X here explicitly, instead of
> >> using say $(OTHER_PROGRAMS) that covers both of these. I know that
> >> the undocumented INCLUDE_DLLS_IN_ARTIFACTS knob uses OTHER_PROGRAMS
> >> by throwing in non-programs like DLLs to it, so that artifacts-tar
> >> target would include them, but perhaps instead of working around the
> >> misdesign of that target, wouldn't it be better to correct its use
> >> of OTHER_PROGRAMS and use it here instead?
> >>
> >> The change (including the "strip scalar, too!" part) should look
> >> like this, I think.
> >
> > Sure.
> >
> >> Also do we need a matching change to CMake and meson?
> >
> > I am unfamiliar with Meson, and do not see anything about stripping in
> > `meson.build` apart from a `--strip` option that is mentioned in a comment
> > (and which I would assume already handles all executables, otherwise the
> > move to Meson really is not worth all the hassle).
>
> That's a great point.
>
> Anyway, the original patch that started this thread is not wrong, so
> let me queue it as-is. Those who want to improve on it can build on
> top.
Yup, Dscho is exactly right. Meson handles stripping natively via the
`--strip` option that you can pass at setup time. If so, it knows to
strip all binaries when installing.
So there's nothing we need to do for Meson, thanks!
Patrick
prev parent reply other threads:[~2025-12-01 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 19:51 [PATCH] make strip: include `scalar` Johannes Schindelin via GitGitGadget
2025-11-17 22:04 ` Junio C Hamano
2025-11-25 17:47 ` Johannes Schindelin
2025-11-25 22:54 ` Junio C Hamano
2025-12-01 7:58 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS1KqrTRxHSGDDZY@pks.im \
--to=ps@pks$(echo .)im \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox