From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Peter Krefting <peter@softwolves•pp.se>
Cc: git@vger•kernel.org
Subject: Re: How to localize "git push"?
Date: Thu, 27 Nov 2025 23:05:14 +0000 [thread overview]
Message-ID: <aSjZKl17Vz4fMXxu@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <f2cb6da7c17e8de829c3e4cb066684e2@softwolves.pp.se>
[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]
On 2025-11-26 at 07:50:15, Peter Krefting wrote:
> Hi!
Hi,
> Re: https://fosstodon.org/@McPringle/115611195011002487
>
> The message shown when running "git push" without any changes queued is
> always shown in English, whereas the corresponding message in "git pull" is
> properly localized.
>
> I looked at the sources, and the string "Everything up-to-date\n" is
> included in both builtin/send-pack.c and transport.c, with both instances
> annotated with a comment "stable plumbing output; do not modify or
> localize".
>
> How do we fix that? Having the message show in English from "git push" is
> confusing. What is the corresponding plumbing command that needs to have it
> machine-readable, so that we can fork that to fix "git push"?
There isn't any tooling in Git that requires that particular message but
it's rather that other software outside of Git may depend on that
output.
It should be noted that "Everything up-to-date" should actually be
"Everything up to date", since it's an abbreviated form of "everything
is up to date" and for most compound adjectives, we only hyphenate them
in English before the noun they modify. However, because there was
supposedly existing software that expected that output, we chose not to
modify those messages at the time that cleanup went in. I am, however,
unable to find any such software that expects that string on GitHub with
a quick search.
Personally, I'm fine with modifying that message unless something like a
`--plumbing` argument is given (or just letting people set
`LC_ALL=C.UTF-8` if they want fixed output), but other people may not
be.
I will say that we changed the following message sometime back for
localization (to uppercase the N in "Needed") and it broke things at my
last company, but we also easily fixed it and I'm pleased that it's now
localized:
----
% git rev-parse --verify nonexistent
fatal: Needed a single revision
% LC_ALL=es_MX.UTF-8 git rev-parse --verify nonexistent
fatal: Se necesitó una revisión singular
% LC_ALL=fr_CA.UTF-8 git rev-parse --verify nonexistent
fatal : Une seule révision attendue
----
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2025-11-27 23:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 7:50 How to localize "git push"? Peter Krefting
2025-11-27 23:05 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSjZKl17Vz4fMXxu@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=peter@softwolves$(echo .)pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox