Subject: Re: [PATCH 01/17] odb: split `struct odb_source` into separate header

From: Patrick Steinhardt <[email-masked]>
Date: Thu, 5 Mar 2026 14:23:11 +0100

On Wed, Mar 04, 2026 at 09:55:11AM -0600, Justin Tobler wrote:
> > diff --git a/odb.h b/odb.h
> > index 68b8ec2289..e13b5b7c44 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -3,6 +3,7 @@
> >  
> >  #include "hashmap.h"
> >  #include "object.h"
> > +#include "odb/source.h"
> 
> Out of curiousity, since we include the header here, it is transitively
> included wherever we are using `struct odb_source`. Ideally should we be
> explicit or would it be best to just rely on this transitively?

Hum, dunno. I think it's fine to just be pragmatic here and only include
"odb.h"?

Patrick