Subject: Re: [PATCH v5 3/3] fast-import: add mode to sign commits with invalid signatures

From: Justin Tobler <[email-masked]>
Date: Thu, 12 Mar 2026 19:17:08 -0500

On 26/03/12 07:58PM, Jeff King wrote:
> On Thu, Mar 12, 2026 at 02:22:28PM -0500, Justin Tobler wrote:
> 
> > +test_expect_success GPGSSH "sign invalid commit with explicit keyid" '
> >  	rm -rf new &&
> >  	git init new &&
> 
> This test is failing on Windows in GitHub's CI.
> 
> You can't see it from the context, but the next line of this test is:
> 
> 	git fast-export --signed-commits=verbatim openpgp-signing >output &&
> 
> But the openpgp-signing branch will only have been created if the GPG
> prereq is set. Should this be referencing ssh-signing instead? Or should
> it be using GPG,GPGSSH as prereqs?

Ahh, it look like this should be referencing ssh-signing. I'll include
this fix in my next version. Thanks! :)

-Justin