Subject: Re: [PATCH 2/6] odb/transaction: use pluggable `begin_transaction()`

From: Patrick Steinhardt <[email-masked]>
Date: Tue, 31 Mar 2026 09:48:33 +0200

On Mon, Mar 30, 2026 at 10:38:31PM -0500, Justin Tobler wrote:
> Each ODB source is expected to provide an ODB transaction implementation
> that should be used when starting a transaction. With d6fc6fe6f8
> (odb/source: make `begin_transaction()` function pluggable, 2026-03-05),
> the `struct odb_source` now provides a pluggable callback for beginning
> transactions. Use the callback provided by the ODB source accordingly.

Yup, this is an obvious oversight on my part.

> Signed-off-by: Justin Tobler <[email-masked]>
> ---
>  odb/transaction.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/odb/transaction.c b/odb/transaction.c
> index 9bf3f347dc..592ac84075 100644
> --- a/odb/transaction.c
> +++ b/odb/transaction.c
> @@ -1,5 +1,5 @@
>  #include "git-compat-util.h"
> -#include "object-file.h"
> +#include "odb/source.h"
>  #include "odb/transaction.h"
>  
>  struct odb_transaction *odb_transaction_begin(struct object_database *odb)

Nice to see that we don't have to care about "object-file.h" anymore.

Patrick