Subject: Re: [PATCH 15/16] repack: introduce `--write-midx=incremental`

From: Taylor Blau <[email-masked]>
Date: Tue, 21 Apr 2026 15:52:47 -0400

On Thu, Apr 16, 2026 at 03:53:28PM -0700, Elijah Newren wrote:
> On Sun, Mar 29, 2026 at 2:41 PM Taylor Blau <[email-masked]> wrote:
> >
> > +       if (!strcmp(var, "repack.midxsplitfactor")) {
> > +               repack_ctx->midx_split_factor = git_config_int(var, value,
> > +                                                              ctx->kvi);
> > +               return 0;
> > +       }
> > +       if (!strcmp(var, "repack.midxnewlayerthreshold")) {
> > +               repack_ctx->midx_new_layer_threshold = git_config_int(var, value,
> > +                                                                     ctx->kvi);
> > +               return 0;
> > +       }
>
> Should there be any sanity checking on appropriate values beyond
> is-an-integer, such as requiring midx_split_factor > 1 ?

Very reasonable, I added some basic sanity checking for both.

Thanks,
Taylor