From: Phillip Wood <phillip.wood123@gmail•com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx•de>,
Phillip Wood <phillip.wood@dunelm•org.uk>
Cc: git@vger•kernel.org, Ayush Chandekar <ayu.chandekar@gmail•com>,
Taylor Blau <me@ttaylorr•com>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail•com>
Subject: Re: [PATCH v2 3/3] commit: print advice when core.commentString=auto
Date: Tue, 26 Aug 2025 14:33:10 +0100 [thread overview]
Message-ID: <af0c22b9-5034-4bbd-9cdd-f1f16d933e4d@gmail.com> (raw)
In-Reply-To: <aIzayan9nFZo4XYv@ugly>
On 01/08/2025 16:18, Oswald Buddenhagen wrote:
> On Thu, Jul 31, 2025 at 04:21:55PM +0100, Phillip Wood wrote:
>> An alternative
>> approach would be to advise the user to run "git config --show-origin"
>> and leave them to figure out how to fix it themselves but that seems
>> rather unfriendly. As we're forcing them to update their config we
>> should try and make that as easy as possible.
>>
> your approach certainly helps the user to fix their acute problem
> quickly, but
> - why should it? it's not like leaving it to the user would cause them a
> huge burden, or that a noteworthy number of users are even going to
> be affected. i don't think the fact that the update is forced
> justifies making it a lot more user friendly than git configuration
> usually is, esp. at this cost in complexity.
I think the fact that we're forcing the user to update does matter
because it means they're having to update their config when they
otherwise would not have to. I'd much rather it gave me a suggestion on
how to proceed rather than told me to check my config and figure out
what to do. There is certainly a complexity cost but I don't think it is
that high. Some of git's reputation for being hard to use is well earned
and I don't want to add to that.
> - i don't think i'd appreciate the tool lecturing me about trivial usage
> patterns, when the real question in that situation is why the option
> was set like that in the first place and whether/how the replacement
> is actually equivalent or even superior.
I don't think offering a suggestion is "lecturing about trivial usage
patterns", I see it as offering assistance to users. The reason the
advice offers two suggestions is because we cannot second guess whether
the user wants to use the default or set a fixed string - it is up to
them to decide.
> - given that it doesn't print the entire decision tree (when
> encountering read-only files), it doesn't necessarily guide the user
> towards the best overall solution. that makes it _less_ user-friendly,
> in a way.
It provides a reasonable way of updating the config that we know will
work when a user does not have write access to the system config. More
experienced users are of course free to update their config as they see fit.
Thanks
Phillip
next prev parent reply other threads:[~2025-08-26 13:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 13:56 [PATCH 0/2] breaking-changes: deprecate support for core.commentChar=auto Phillip Wood
2025-07-08 13:56 ` [PATCH 1/2] breaking-changes: deprecate support for core.commentString=auto Phillip Wood
2025-07-08 15:28 ` Ayush Chandekar
2025-07-09 9:40 ` Phillip Wood
2025-07-08 13:56 ` [PATCH 2/2] commit: print advice when core.commentString=auto Phillip Wood
2025-07-08 18:51 ` [PATCH 0/2] breaking-changes: deprecate support for core.commentChar=auto Junio C Hamano
2025-07-09 9:38 ` Phillip Wood
2025-07-09 16:20 ` Junio C Hamano
2025-07-11 15:09 ` Phillip Wood
2025-07-11 17:07 ` Junio C Hamano
2025-07-12 8:01 ` Oswald Buddenhagen
2025-07-12 14:06 ` Junio C Hamano
2025-07-26 23:15 ` Junio C Hamano
2025-07-27 15:46 ` Phillip Wood
2025-07-09 1:27 ` Junio C Hamano
2025-07-09 1:52 ` Ayush Chandekar
2025-07-09 9:38 ` Phillip Wood
2025-07-31 15:21 ` [PATCH v2 0/3] " Phillip Wood
2025-07-31 15:21 ` [PATCH v2 1/3] breaking-changes: deprecate support for core.commentString=auto Phillip Wood
2025-07-31 20:49 ` Junio C Hamano
2025-07-31 15:21 ` [PATCH v2 2/3] config: warn on core.commentString=auto Phillip Wood
2025-07-31 21:17 ` Junio C Hamano
2025-08-01 10:37 ` Phillip Wood
2025-08-01 14:36 ` Oswald Buddenhagen
2025-07-31 15:21 ` [PATCH v2 3/3] commit: print advice when core.commentString=auto Phillip Wood
2025-08-01 15:18 ` Oswald Buddenhagen
2025-08-01 17:19 ` Junio C Hamano
2025-08-26 13:33 ` Phillip Wood [this message]
2025-08-27 8:19 ` Oswald Buddenhagen
2025-08-27 16:39 ` Junio C Hamano
2025-08-27 22:38 ` Oswald Buddenhagen
2025-08-01 3:50 ` [PATCH v2 0/3] breaking-changes: deprecate support for core.commentChar=auto Junio C Hamano
2025-08-01 10:36 ` Phillip Wood
2025-08-01 16:41 ` Junio C Hamano
2025-08-26 13:35 ` [PATCH v3 " Phillip Wood
2025-08-26 13:35 ` [PATCH v3 1/3] breaking-changes: deprecate support for core.commentString=auto Phillip Wood
2025-08-26 13:35 ` [PATCH v3 2/3] config: warn on core.commentString=auto Phillip Wood
2025-08-26 15:52 ` Junio C Hamano
2025-08-27 15:29 ` Phillip Wood
2025-08-27 18:55 ` Junio C Hamano
2025-08-26 13:35 ` [PATCH v3 3/3] commit: print advice when core.commentString=auto Phillip Wood
2025-08-27 15:27 ` [PATCH v4 0/3] breaking-changes: deprecate support for core.commentChar=auto Phillip Wood
2025-08-27 15:27 ` [PATCH v4 1/3] breaking-changes: deprecate support for core.commentString=auto Phillip Wood
2025-08-27 15:27 ` [PATCH v4 2/3] config: warn on core.commentString=auto Phillip Wood
2025-08-27 15:27 ` [PATCH v4 3/3] commit: print advice when core.commentString=auto Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0c22b9-5034-4bbd-9cdd-f1f16d933e4d@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=ayu.chandekar@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=oswald.buddenhagen@gmx$(echo .)de \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox