From: LorenzoPegorari <lorenzo.pegorari2002@gmail•com>
To: git@vger•kernel.org
Cc: Taylor Blau <me@ttaylorr•com>, Junio C Hamano <gitster@pobox•com>,
Patrick Steinhardt <ps@pks•im>, fox <fox.gbr@townlong-yak•com>,
Jeff King <peff@peff•net>
Subject: [PATCH] http: fix memory leak in fetch_and_setup_pack_index()
Date: Tue, 19 May 2026 16:54:45 +0200 [thread overview]
Message-ID: <agx5tblaCZNsYEBq@lorenzo-VM> (raw)
Inside the function `fetch_and_setup_pack_index()`, when the pack
obtained using `fetch_pack_index()` fails to be verified by
`parse_pack_index()`, the function returns without closing and freeing
said pack.
Fix this by calling `close_pack_index()` to munmap the index file for
the leaking pack (which might have been mmapped by `fetch_pack_index()`
or `verify_pack_index()`), and then free it.
Signed-off-by: LorenzoPegorari <lorenzo.pegorari2002@gmail•com>
---
http.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/http.c b/http.c
index 67c9c6fc60..c28be26ad9 100644
--- a/http.c
+++ b/http.c
@@ -2545,11 +2545,13 @@ static int fetch_and_setup_pack_index(struct packfile_list *packs,
}
ret = verify_pack_index(new_pack);
- if (!ret)
- close_pack_index(new_pack);
+
+ close_pack_index(new_pack);
free(tmp_idx);
- if (ret)
+ if (ret) {
+ free(new_pack);
return -1;
+ }
packfile_list_prepend(packs, new_pack);
return 0;
--
2.54.0.dirty
next reply other threads:[~2026-05-19 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 14:54 LorenzoPegorari [this message]
2026-05-19 19:17 ` [PATCH] http: fix memory leak in fetch_and_setup_pack_index() Jeff King
2026-05-28 1:22 ` Lorenzo Pegorari
2026-05-29 5:32 ` Jeff King
2026-05-28 23:49 ` [PATCH v2] " LorenzoPegorari
2026-05-29 5:36 ` Jeff King
2026-05-29 5:40 ` Jeff King
2026-06-01 13:34 ` Lorenzo Pegorari
2026-06-01 13:27 ` Lorenzo Pegorari
2026-06-01 13:51 ` [PATCH v3 0/2] " LorenzoPegorari
2026-06-01 13:52 ` [PATCH v3 1/2] http: cleanup function fetch_and_setup_pack_index() LorenzoPegorari
2026-06-01 13:52 ` [PATCH v3 2/2] http: fix memory leak in fetch_and_setup_pack_index() LorenzoPegorari
2026-06-02 6:24 ` [PATCH v3 0/2] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agx5tblaCZNsYEBq@lorenzo-VM \
--to=lorenzo.pegorari2002@gmail$(echo .)com \
--cc=fox.gbr@townlong-yak$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox