Subject: Re: [PATCH v5 04/10] test-http-server: add stub HTTP server test helper

From: Victoria Dye <[email-masked]>
Date: Thu, 12 Jan 2023 11:57:57 -0800

Matthew John Cheetham via GitGitGadget wrote:
> From: Matthew John Cheetham <[email-masked]>
> 
> Introduce a mini HTTP server helper that in the future will be enhanced
> to provide a frontend for the git-http-backend, with support for
> arbitrary authentication schemes.
> 
> Right now, test-http-server is a pared-down copy of the git-daemon that
> always returns a 501 Not Implemented response to all callers.

Between your earlier response [1] and this iteration of the patch, all of
the comments from my previous review [2] have been addressed. The changes to
drop the dependency on cURL also look correct to me. Thanks!

[1] https://lore.kernel.org/git/[email-masked]/
[2] https://lore.kernel.org/git/[email-masked]/

> 
> Signed-off-by: Matthew John Cheetham <[email-masked]>
> ---
>  Makefile                            |   1 +
>  contrib/buildsystems/CMakeLists.txt |  11 +-
>  t/helper/.gitignore                 |   1 +
>  t/helper/test-http-server.c         | 385 ++++++++++++++++++++++++++++
>  4 files changed, 396 insertions(+), 2 deletions(-)
>  create mode 100644 t/helper/test-http-server.c